Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pawbana
force-pushed
the
pb/responses-remove-paramswrap-part2
branch
3 times, most recently
from
b35d815 to
c0f64e9
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-blocking
branch
2 times, most recently
from
6478817 to
f55e5d4
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-part2
branch
from
c0f64e9 to
b0e75df
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-blocking
branch
from
f55e5d4 to
11aeeb0
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-part2
branch
from
b0e75df to
f06f538
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-blocking
branch
from
11aeeb0 to
be0adac
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-part2
branch
from
f06f538 to
09ff296
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-part2
branch
from
09ff296 to
529a39b
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-blocking
branch
from
be0adac to
809aae2
Compare
dannykopping
approved these changes
Mar 16, 2026
pawbana
force-pushed
the
pb/responses-remove-paramswrap-blocking
branch
from
809aae2 to
93d2b9c
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-part2
branch
2 times, most recently
from
00c15d4 to
af9c082
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-blocking
branch
from
93d2b9c to
5f14de7
Compare
pawbana
force-pushed
the
pb/responses-remove-paramswrap-part2
branch
from
af9c082 to
746f730
Compare
ssncferreira
approved these changes
Mar 18, 2026
Contributor
ssncferreira
left a comment
ssncferreira
left a comment
There was a problem hiding this comment.
LGTM 💪 just a couple of nits
provider/copilot.go
Outdated
| return nil, fmt.Errorf("read body: %w", err) | ||
| } | ||
| reqPayload, err := responses.NewResponsesRequestPayload(payload) | ||
| reqPayload, err := responses.NewResponsesRequestPayload(payload, slog.Make()) |
Contributor
There was a problem hiding this comment.
This creates a no-op logger, right? Maybe we can pass the logger as a param to lastUserPrompt (which is currently the only one needing the logger), since it is called from the interception, it could use the interception logger, no?
Contributor
Author
There was a problem hiding this comment.
Ah good catch, I was too hasty and somehow though this is test file.
This makes me re-think adding logger as part of ResponsesRequestPayload struct since there is no logger to pass here (logger is set in Setup method). I'll revet the logger change and add it as a parameter to lastUserPrompt which is a bit ugly but I don't want to make this PR even more complicated.
intercept/responses/reqpayload.go
Outdated
| // empty string, false, nil. Unexpected shapes are treated as unsupported and do | ||
| // not fail the request path. | ||
| func (p *ResponsesRequestPayload) lastUserPrompt(ctx context.Context) (string, bool, error) { | ||
| inputItems := gjson.GetBytes(p.payload, reqPathInput) |
Contributor
There was a problem hiding this comment.
nit: Maybe we should keep the p nil check?
Contributor
Author
pawbana
changed the base branch from
pb/responses-remove-paramswrap-blocking
to
graphite-base/215
… to sturct and methods on pointer type
pawbana
force-pushed
the
pb/responses-remove-paramswrap-part2
branch
from
2e26427 to
1aa5101
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved
correlatingToolCallID()andlastUserPrompt()methods fromresponsesInterceptionBasetoResponsesRequestPayload