🤖 refactor: clean up workspace runtime contract helpers#3014
🤖 refactor: clean up workspace runtime contract helpers#3014ammar-agent wants to merge 2 commits intomainfrom
Conversation
Follow up on the submodule workspace work by extracting shared WorktreeManager cleanup helpers and reusing runtime identity plumbing in runtimeFactory. This keeps workspace delete/rollback flows easier to follow without changing behavior. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$79.98`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=79.98 -->
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ammar-agent
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f41d257c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Continue the workspace runtime cleanup by centralizing the shared init-hook flow, threading persisted workspace identity through runtime recreation, and using directoryName consistently for workspace/container paths. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$153.79`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=153.79 -->
ammar-agent
force-pushed
the
refactor/workspace-runtime-cleanup
branch
from
2f41d25 to
1e0a43b
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Broaden the workspace runtime cleanup so the runtime contract is more consistent across local, worktree, SSH, Docker, and devcontainer flows. This keeps the earlier
WorktreeManager/runtimeFactorycleanup from #3014, then adds shared init-hook orchestration, persisted workspace identity plumbing, and consistentdirectoryNameusage for workspace/container path identity.Background
The first pass of runtime cleanup reduced some local duplication, but the runtime contract still had a few horizontal seams with noticeable drift:
initWorkspace()hook-only flow,This follow-up keeps those cleanup threads aligned across the runtime layer instead of fixing each runtime in isolation.
Implementation
WorktreeManager.deleteWorkspace()/runtimeFactoryhelper cleanup from this PRrunWorkspaceInitHook(...)insrc/node/runtime/initHook.tsand reuse it inLocalRuntime,WorktreeRuntime,SSHRuntime,DockerRuntime, andDevcontainerRuntimeMUX_*env flowcreateRuntimeForWorkspace(...)to pass the persistednamedWorkspacePath, so recreated runtimes start from the stored workspace identity instead of reconstructing it laterdirectoryNamethrough worktree/ssh/devcontainer/docker workspace creation so workspace/container paths follow the persisted workspace entry name while git checkout behavior still followsbranchNameValidation
bun test src/node/runtime/initHook.test.ts src/node/runtime/runtimeHelpers.test.ts src/node/runtime/runtimeFactory.test.ts src/node/runtime/SSHRuntime.test.ts src/node/worktree/WorktreeManager.test.ts src/node/runtime/DevcontainerRuntime.test.ts src/node/runtime/DockerRuntime.test.ts src/node/runtime/LocalRuntime.test.ts src/node/runtime/submoduleSyncRuntimes.test.tsmake static-checkRisks
Low to moderate. The changes are intended to be behavior-preserving, but they touch shared runtime initialization and workspace path identity, so regressions would most likely show up as init-hook execution differences, recreated-runtime path mismatches, or incorrect workspace/container naming during create flows.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$153.79