Conversation
|
@codex review |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13fe8f4a57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
13fe8f4 to
ddf337c
Compare
|
@codex review Please take another look. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddf337cabf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please take another look. |
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
ddf337c to
610627f
Compare
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
610627f to
28d5142
Compare
|
@codex review Please take another look. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28d514256d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
28d5142 to
2525e49
Compare
|
@codex review Please take another look. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2525e49d1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please take another look. |
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
2525e49 to
f964875
Compare
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
f964875 to
44e6cec
Compare
|
@codex review Please take another look. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44e6ceccd5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please take another look. |
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
44e6cec to
c13a637
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c13a63782b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
c13a637 to
7241d94
Compare
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
7241d94 to
6774efa
Compare
|
@codex review Follow-up simplification per explicit user direction:
That keeps Ask removal focused on agent selection migration while avoiding any further Ask-vs-Auto settings compatibility logic. |
Remove the last Ask-specific compatibility path that carried legacy Ask model settings forward after remapping persisted Ask mode selections to Auto. ACP now remaps legacy Ask mode to Auto without resurrecting aiSettingsByAgent.ask, and workspace AI-setting persistence keeps explicit ask writes separate from Auto so custom or legacy Ask state does not get mixed into Auto's bucket. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$122.62`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=122.62 -->
ammar-agent
force-pushed
the
refactor/remove-ask-agent
branch
from
6774efa to
0ff122c
Compare
|
@codex review Latest push includes the staged ACP + workspace AI-settings simplification:
|
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
## Summary Periodic auto-cleanup PR. Each commit is an independent, behavior-preserving refactor found by scanning recent `main` commits. ## Current cleanup **Remove dead ask-agent fallback from agentResolution** — The ask agent was removed in 395e956 (#3047). The special-case fallback path (`ask → auto → exec`) in the agent definition loader's catch block is now dead code, since the migration in that same PR already remaps persisted `ask` selections to `auto` before this code path is reached. Simplified the catch block to always fall back to `exec` directly (−8 lines). ## Validation - `make static-check` passes (ESLint, TypeScript, Prettier) Auto-cleanup checkpoint: fda7812 --- _Generated with `mux` • Model: `anthropic:claude-opus-4-6` • Thinking: `xhigh` • Cost: `N/A`_ <!-- mux-attribution: model=anthropic:claude-opus-4-6 thinking=xhigh costs=N/A --> --------- Co-authored-by: mux-bot[bot] <264182336+mux-bot[bot]@users.noreply.github.com>
2 participants
Summary
Remove the built-in Ask agent from Mux and migrate legacy persisted Ask selections to the default Auto router.
Background
Ask overlapped with the existing Auto/Explore flow and added extra built-in surface area to maintain. This change removes the built-in agent while keeping old saved preferences from breaking by remapping persisted
askselections toauto.Implementation
ask.mddefinition and regenerated the embedded built-in agent/docs artifactsaskvalues now resolve toautoacross browser and node codepathsValidation
make static-checkbun test tests/ipc/acp.configOptions.test.ts tests/ipc/acp.resolveAgentAiSettings.test.ts src/browser/contexts/AgentContext.test.tsx src/browser/hooks/useDraftWorkspaceSettings.test.tsx src/browser/features/ChatInput/useCreationWorkspace.test.tsx src/node/services/agentDefinitions/resolveToolPolicy.test.tsRisks
Low-to-moderate risk in agent selection and persisted preference migration paths. The main regression risk is old saved Ask preferences resolving incorrectly, which is covered by targeted browser/node tests and the shared normalization helper.
Generated with
mux• Model:openai:gpt-5.4• Thinking:high• Cost:$9.45