Conversation
Expose detected local Tailscale addresses in API server status and allow the remote access experiment to bind mux to one of them. Generated with mux • Model: openai:gpt-5.5 • Thinking: xhigh • Cost: $0.00
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dab07c185
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Avoid labeling generic 100.64.0.0/10 addresses as Tailscale unless the interface name or Tailscale CLI output proves the address belongs to Tailscale. Generated with mux • Model: openai:gpt-5.5 • Thinking: xhigh • Cost: $0.00
|
@codex review Please take another look. I tightened generic 100.64.0.0/10 detection to require Tailscale CLI proof and resolved the prior thread. |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Adds Tailscale-aware bind host selection to the remote access experiment so users can bind mux to a detected local Tailscale address instead of only localhost or all interfaces.
Implementation
tailscale ipto prove generic interface addresses belong to Tailscale.tailscaleBindHosts.apiServerBindHostsetting.Validation
make static-checkbun test node/services/serverService.test.tsRisks
Low. The change extends the existing custom bind-host path and only changes remote access settings when the user explicitly selects a Tailscale address. Generic 100.64.0.0/10 addresses now require Tailscale CLI proof before being labeled as Tailscale.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$0.00