🤖 fix: preserve subagent retention setting on partial saves#3245
Merged
🤖 fix: preserve subagent retention setting on partial saves#3245
Conversation
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
Author
|
@codex review |
Partial config saves can omit newer optional task flags while still satisfying the API schema. Merge incoming task settings over existing normalized settings so preserveSubagentsUntilArchive remains sticky across unrelated saves. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$0.00`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=0.00 -->
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves optional task settings across partial
config.saveConfigcalls so enabling “Preserve subagents until the workspace gets archived” no longer gets silently reset by unrelated settings saves.Background
The task cleanup path already respects
preserveSubagentsUntilArchivewhen the setting remains true. The bug was that the API schema allows clients to save only the required numeric task limits, and the router normalized that partial payload as a full task-settings replacement. Missing optional flags therefore defaulted back tofalse, allowing completed subagents to be cleaned up before archive.Implementation
Validation
bun test src/node/orpc/router.test.tsbun test src/node/services/taskService.test.ts -t "preserve subagents until archive"make typecheckmake lintmake fmt-checkmake static-checkRisks
Low. The change is scoped to
config.saveConfigtask settings persistence and only preserves existing optional values when a client omits them. Explicit task-setting changes still win.Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$0.00