Security: Command injection vulnerability in git diff command builder#3253
Open
tomaioo wants to merge 1 commit into
Open
Security: Command injection vulnerability in git diff command builder#3253tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
mobile/src/utils/git/gitCommands.ts builds git commands using string interpolation instead of proper argument escaping. The diffBase, pathFilter parameters are directly interpolated into the command string without sanitization, allowing shell injection attacks. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Command injection vulnerability in git diff command builder
Problem
Severity:
Critical| File:mobile/src/utils/git/gitCommands.ts:L28mobile/src/utils/git/gitCommands.ts builds git commands using string interpolation instead of proper argument escaping. The diffBase, pathFilter parameters are directly interpolated into the command string without sanitization, allowing shell injection attacks.
Solution
Use an array-based command builder instead of string interpolation. Pass parameters as separate arguments to the git command to let git handle escaping properly. Example: ['git', 'diff', diffBase, '--', pathFilter]
Changes
mobile/src/utils/git/gitCommands.ts(modified)