Pin third-party action to immutable ref in release workflow - #3463
Pin third-party action to immutable ref in release workflow#3463robnester-rh wants to merge 1 commit into
Conversation
Pin jlumbroso/free-disk-space from mutable @main to SHA digest (v1.3.1). Re-enable step-security/harden-runner at v2.20.1 in audit mode. Add helpers:pinGitHubActionDigests Renovate preset for automatic future pinning. Resolves: EC-2045 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe release workflow now enables runner hardening and pins action revisions. Renovate now applies the GitHub Actions digest-pinning preset. ChangesRelease security configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🤖 Finished Review · ✅ Success · Started 3:35 PM UTC · Completed 3:46 PM UTC |
PR Summary by QodoPin GitHub Actions to SHA digests and re-enable harden-runner in release
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ReviewFindingsHigh
Low
Labels: PR modifies GitHub Actions workflow files and Renovate configuration for action digest pinning Next steps:
|
|
Regarding the fullsend protected-path finding: this PR intentionally modifies |
Summary
Pinned
jlumbroso/free-disk-spacefrom mutable@mainto immutable SHA@54081f138730dfa15788a46383842cd2f914a1be(v1.3.1). This action runs in a job withcontents: write,pages: write, andid-token: writepermissions — a compromised upstream pushing tomaincould sign and publish arbitrary releases. CVSS 8.0.Re-enabled
step-security/harden-runnerat v2.20.1 (was commented out at v2.4.1). The original concern was disk space exhaustion, butfree-disk-spacenow reclaims ~30GB before subsequent steps run. Inegress-policy: auditmode, harden-runner monitors network egress without blocking — low risk, high visibility into what the release job contacts.Added
helpers:pinGitHubActionDigeststorenovate.json. This Renovate preset does two things: (1) automatically opens PRs to pin any future actions added with a mutable tag ref (e.g.@v3) to their full SHA digest, and (2) keeps existing SHA-pinned actions up to date when new versions are released. This is scoped toclionly — it extends the shared org config without modifying it, so it can be promoted toconforma/.githublater if the team wants org-wide coverage.Test plan
Resolves: EC-2045
🤖 Generated with Claude Code