fix(export): include inflection-db in DB_REQUIRED_EXTENSIONS#1346
Closed
pyramation wants to merge 2 commits into
Closed
fix(export): include inflection-db in DB_REQUIRED_EXTENSIONS#1346pyramation wants to merge 2 commits into
pyramation wants to merge 2 commits into
Conversation
The exported tenant modules contain SQL that references inflection_db.* functions (get_namespace_name, get_field_name, etc.) emitted by constructive-db generators. inflection-db is a public pgpm module, so listing it as a required extension keeps it in the generated .control and package.json dependencies and removes the need for downstream post-export SQL patching.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This reverts commit 4fb9643.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
inflection-dbtopgpm/export/src/export-utils.tsDB_REQUIRED_EXTENSIONS.constructive-dbgenerators emit SQL that callsinflection_db.*functions (e.g.,get_namespace_name,get_field_name) in tenant triggers and index/constraint names.inflection-dbis a public pgpm module, so listing it as a required extension means a fresh module export will include it in the generated.controlrequiresandpackage.jsondependencies without any post-export patching.The downstream
diligence-app-demopackages/export/src/run-export.tspreviously in-lined these calls and patchedinflection_dbreferences afterexportMigrations; withinflection-dbpresent in the dependency list, that patch is unnecessary.Link to Devin session: https://app.devin.ai/sessions/6bde130e8b01413c925b85ddb936df31
Requested by: @pyramation