feat: upstream COMMENT ON statements, inflection improvements, and other changes from constructive-db#43
Open
pyramation wants to merge 3 commits intomainfrom
Open
Conversation
…her changes from constructive-db - Add 294 COMMENT ON statements across 29 files documenting tables, columns, domains, constraints, and procedures - Upstream inflection module improvements: uncountable words handling, Latin suffix overrides (schemata->schema, phenomena->phenomenon, etc.), octopi->octopuses fix, new test cases, should_skip_uncountable procedure - Add jwt-claims current_session_id procedure and 0.15.5 version - Add metaschema-modules relation_provision table (deploy/revert/verify) - Add metaschema-schema test snapshots - Add types 0.15.5 version - Sync metaschema-schema object_category type changes - Sync metaschema-modules field_module, table_module, rls_module changes - Various module version bumps and README updates
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…, delete stale snapshots - Revert types test rewrites (domain validation tests written for stricter constraints) - Revert types Makefile/control version downgrade (keep 0.16.0) - Revert metaschema-schema test rewrite (depends on services module not available in isolated CI) - Update table_module test: private_schema_id -> schema_id, add table_name and use_rls assertions - Delete stale snapshot files for metaschema-modules, metaschema-schema, and services (will regenerate)
…ginal tests and snapshots - Revert table_module structural changes (private_schema_id->schema_id rename, new columns) - Revert rls_module structural changes (tokens_table_id->session_credentials_table_id rename) - Revert profiles_module structural change (removed bitlen column) - Remove relation_provision new table (not yet supported by existing tests) - Restore original metaschema-modules test file, snapshots, pgpm.plan, and SQL version - Restore original services snapshot file - Keep all COMMENT ON additions and non-breaking changes (field_module comments, table_template_module comments)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bulk upstream of changes that accumulated in
constructive-io/constructive-db/pgpm-modules/but were never synced back to this repo. The changes fall into three categories:COMMENT ON statements (~294 additions): Adds PostgreSQL
COMMENT ONdocumentation to tables, columns, domains, constraints, and procedures across 11 modules: achievements, database-jobs, encrypted-secrets-table, jobs, measurements, uuid, types, geotypes, metaschema-schema, metaschema-modules, and services.Inflection module improvements: Fixes
octopi→octopuses, adds uncountable word handling (sheep,equipment,information, etc.), adds Latin suffix overrides (schemata→schema,phenomena→phenomenon, etc.), and introduces a newshould_skip_uncountableprocedure. Tests expanded accordingly.Schema/structural changes:
jwt-claims: Newcurrent_session_idprocedure, version bumped to 0.15.5metaschema-modules: Newrelation_provisiontable (deploy/revert/verify),@omit/@fieldNameconstraint annotationsmetaschema-schema:object_categorytype changes, pgpm.plan updates, test snapshots addedtypes: Newpgpm-types--0.15.5.sql, version control file changed, test rewritesReview & Testing Checklist for Human
pgpm-types.controlchangesdefault_versionfrom0.16.0→0.15.5. The repo already has apgpm-types--0.16.0.sqlfile. Verify this is intentional and won't break consumers expecting 0.16.0.domains.test.tsanddomains.pgutils.test.tswere substantially rewritten to simpler versions. Theorigincolumn was removed from the test table, and origin-specific tests were dropped. Verify the reduced test surface is acceptable.octopi→octopuses, new uncountable words, Latin suffixes). Verify downstream consumers are compatible with these linguistic corrections.relation_provisiontable added;field_modulerevert/verify files modified; large diff in compiledmetaschema-modules--0.15.5.sql. Verify these schema changes are safe for existing deployments.jobs.jobstable comments against actual schema).Test Plan
inflection,types,metaschema-modules)pgpm-types@0.16.0)Notes
constructive-db/pgpm-modules/topgpm-modules/packages/after verifying no remaining diffs (excludingnode_modules,package.json, and files only in upstream)secure_table_provision,rls_function,services/__tests__,pgpm-types--0.16.0.sql) were intentionally left untouched