Conversation
.github/workflows/ci.yml
Outdated
| # /usr/local is not writable from GitHub Actions' user | ||
| sudo unzip protoc-21.5-linux-x86_64.zip -d /usr/local | ||
| - name: Install protoc-gen-go | ||
| run: go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.28 |
There was a problem hiding this comment.
Curious on having this vs
- remote: buf.build/grpc/go:v1.2.0
out: .
opt:
- paths=source_relativein buf.gen.yaml
What are benefits?
There was a problem hiding this comment.
That was for reducing the size of the diff, but it doesn't actually affect the output. Let me remove the flag.
There was a problem hiding this comment.
Oh sorry. I thought you were talking about -paths=source_relative. Does buf.build/grpc/go:VERSION lock the version? Let me double-check.
There was a problem hiding this comment.
The only problem I got was https://buf.build/docs/bsr/rate-limits/ and I made my own account to be authenticated.
kzys
force-pushed
the
buf
branch
2 times, most recently
from
aa37a61 to
595401c
Compare
kzys
force-pushed
the
buf
branch
2 times, most recently
from
8d4f9a7 to
727b2de
Compare
| name: "github.com/containerd/cgroups/cgroup2/stats/metrics.proto" | ||
| file: { | ||
| name: "cgroup2/stats/metrics.proto" | ||
| package: "io.containerd.cgroups.v2" | ||
| message_type { | ||
| message_type: { |
There was a problem hiding this comment.
Apparently not having : is valid, but the new implementation always outputs :.
https://protobuf.com/docs/language-spec
The grammar only allows the separating colon (:) between field name and value to be omitted when the value is a message literal or a list of message literals. This still allows an empty list to be used without a preceding colon.
|
The latest Buf updates on your PR. Results from workflow CI / proto (pull_request).
|
Like containerd did recently, we can migrate from protobuild to buf. containerd/containerd#12762 Signed-off-by: Kazuyoshi Kato <kazuyoshi.kato@baseten.co>
| uses: bufbuild/buf-action@v1 | ||
| with: | ||
| # We use the action to install buf. | ||
| setup_only: true |
There was a problem hiding this comment.
The action no longer posts PR comments because of setup_only:true.
2 participants
Like containerd did recently, we can migrate from protobuild to buf.
containerd/containerd#12762