fix container can't be started when task status is created#4944
Open
ningmingxiao wants to merge 1 commit into
Open
fix container can't be started when task status is created#4944ningmingxiao wants to merge 1 commit into
ningmingxiao wants to merge 1 commit into
Conversation
AkihiroSuda
reviewed
May 29, 2026
Contributor
Author
There was a problem hiding this comment.
I haven't figured out how to add test cases yet.
AkihiroSuda
reviewed
May 30, 2026
AkihiroSuda
reviewed
May 30, 2026
| } | ||
| if _, err := oldTask.Delete(ctx); err != nil { | ||
| log.G(ctx).WithError(err).Debug("failed to delete old task") | ||
| log.G(ctx).WithError(err).Errorf("failed to delete old task") |
Contributor
Author
There was a problem hiding this comment.
here if old task is not deleted, new task can't be created. and default log level is debug, I think we can use error level @AkihiroSuda
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nerdctl start container failed if get staus timeout
nerdctl can't start this container anymore.
reproduce
nerdctl run -d busybox sleep 10
c1a3a060f42feabdd2fd7440c05c5905a918ec1cad2ebf9e34e8ca1fa9921a80
wait container exited
and add some sleep here
3 ./nerdctl start c1a and then kill "nerdctl start" (will find runc init is running)
FATA[0000] 1 errors:
task c1a3a060f42feabdd2fd7440c05c5905a918ec1cad2ebf9e34e8ca1fa9921a80: already exists
@AkihiroSuda