fix/esm-js-extension-issue #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back merge
fix: ESM compatibility fixes and improved error handling
Coverage report
Test suite run success128 tests passing in 7 suites. Report generated by 🧪jest coverage report action from 95f925b |
Coverage report
Test suite run success128 tests passing in 7 suites. Report generated by 🧪jest coverage report action from 95f925b |
fix: update esm export path to include .js extension
fix: update readme
nadeem-cs
approved these changes
Jan 12, 2026
timbenniks
reviewed
Jan 12, 2026
timbenniks
left a comment
timbenniks
left a comment
There was a problem hiding this comment.
If this works, let's merge. However. I feel like the postbuild.js file is kind of messy. Perhaps we should investigate the voidzero toolchain for this SDK.
aman19K
previously approved these changes
Jan 12, 2026
|
@nadeem-cs @harshithad0703 , before merging the PR pls resolve this #176 (review) |
Contributor
|
@timbenniks Its working for now. We'll go ahead for release with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.