[codex] fix(gemini): pass custom http options to sdk#12014
Open
yzlu0917 wants to merge 1 commit intocontinuedev:mainfrom
Open
[codex] fix(gemini): pass custom http options to sdk#12014yzlu0917 wants to merge 1 commit intocontinuedev:mainfrom
yzlu0917 wants to merge 1 commit intocontinuedev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestOptions.headersandrequestOptions.timeoutinto theGoogleGenAISDK viahttpOptionsapiBasevalues into the SDK so chat/stream requests use the same endpoint override as embed requestsWhy
Continue's Gemini adapter already honored custom request options for the manual
embed()path, but chat and streaming requests were created throughGoogleGenAIwithout any of the configuredrequestOptions.headersor customapiBase. That meant API gateways expecting custom auth headers likex-api-keycould work for one path and silently fail for the main chat path.This change keeps the SDK-based Gemini implementation, but makes its HTTP configuration consistent with the rest of the adapter.
Validation
npm test -- src/test/gemini-adapter.vitest.ts src/test/main.test.tsinpackages/openai-adaptersCloses #12008
Summary by cubic
Fixes the Gemini adapter to pass custom headers and timeouts to the
@google/genaiSDK and to forward a customapiBasefor chat and streaming. This makes gateway-authenticated requests work consistently across embed, chat, and stream.httpOptionsfromrequestOptions.headersandrequestOptions.timeoutand pass toGoogleGenAI.apiBaseto the SDK (clearsapiVersion) so chat/stream use the same endpoint as embeds.httpOptions.Written for commit daca94d. Summary will update on new commits.