[codex] fix(skills): load symlinked markdown skills#12025
Open
yzlu0917 wants to merge 1 commit intocontinuedev:mainfrom
Open
[codex] fix(skills): load symlinked markdown skills#12025yzlu0917 wants to merge 1 commit intocontinuedev:mainfrom
yzlu0917 wants to merge 1 commit intocontinuedev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_skillworking by enumerating first-level skill directories instead of relying on recursive directory walks that skip symlinks.continue/skills/<skill>directories for both loadersWhy
npx skills add ... --skill <name>can install skills into a project via symlink. Before this change, those symlinked skill directories were skipped during skill discovery, so CLI skill listings and theread_skilltool could not find the installed skill.Validation
npm test -- src/util/loadMarkdownSkills.test.tsinextensions/clinpm run vitest -- config/markdown/loadMarkdownSkills.vitest.tsincorenpm run lintinextensions/cli(passes with 2 pre-existing warnings)git diff --checkCloses #11985
Summary by cubic
Include symlinked markdown skills in discovery for both core and the CLI so skills installed via symlink show up and are readable by
read_skill. Adds tests to prevent regressions.SKILL.mdin symlinked directories under project and global skills dirs..continue/skills/<skill>and verifyread_skillreturns content and files.Written for commit 3a93696. Summary will update on new commits.