fix(cli): restrict stdio MCP environment inheritance - #13059
Open
d3f4w2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stdio MCP servers currently receive every variable from
process.env, including unrelated cloud credentials, database secrets, and API tokens. This change stops copying the ambient environment into each server configuration and lets the MCP SDK apply its platform-safe default environment, while preserving variables explicitly configured for that server.This also avoids mutating
serverConfig.envwhile constructing the transport.Fixes #13010.
AI Code Review
@continue-reviewThis contribution was prepared with AI assistance under the contributor's authorization and review.
Checklist
Screen recording or screenshot
Not applicable; this changes the stdio MCP subprocess environment and has no UI surface.
Tests
process.env, initializes an stdio MCP server with one explicit variable, and verifies only the explicit variable is passed toStdioClientTransport.npm test -- --run src/services/MCPService.test.ts— 21 passedgit diff --checkpassedThe standalone CLI
tsc --noEmitcommand still reports existing NodeNext import-extension errors incore/files outside this diff; the production esbuild bundle completes successfully.