Skip to content

Conversation

@sestinj
Copy link
Contributor

@sestinj sestinj commented Dec 22, 2025

Summary

Fixes issue where hub loading errors were being swallowed and replaced with "Not a markdown file" error message.

When hub loading fails for a path that looks like a hub slug (e.g., continuedev/default-hub-cloud-agent) and is NOT a markdown file, the code now re-throws the actual hub error instead of showing "Not a markdown file". This preserves the real error (e.g., network error, auth error, not found) instead of a confusing generic message.

Test plan

  • Existing tests updated to match new behavior
  • All tests pass locally

🤖 Generated with Claude Code


Summary by cubic

Fixes error handling for hub slugs by re-throwing the actual hub error for non-markdown paths instead of showing "Not a markdown file", so users see the real network/auth/not-found error.

  • Bug Fixes
    • Only fall back to loading from a file when the path is a markdown file; otherwise re-throw the hub error for hub slugs (owner/agent).
    • Updated tests to assert the new behavior.

Written for commit f644c88. Summary will update automatically on new commits.

When hub loading fails for a path that looks like a hub slug (owner/agent)
and is NOT a markdown file, re-throw the hub error instead of showing
"Not a markdown file". This preserves the actual error from the hub
(e.g., network error, auth error, not found) instead of a confusing
generic message.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@sestinj sestinj requested a review from a team as a code owner December 22, 2025 21:46
@sestinj sestinj requested review from RomneyDa and removed request for a team December 22, 2025 21:46
@continue
Copy link
Contributor

continue bot commented Dec 22, 2025

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

@continue-development-app
Copy link

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

1 similar comment
@continue-development-app
Copy link

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 22, 2025
@github-actions
Copy link

github-actions bot commented Dec 22, 2025

✅ Review Complete

Code Review Summary

⚠️ AI review failed. Please check the Continue API key and configuration.

Troubleshooting

  • Verify the CONTINUE_API_KEY secret is set correctly
  • Check that the organization and config path are valid
  • Ensure the Continue service is accessible

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jan 5, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2026
@RomneyDa RomneyDa merged commit b24adaa into main Jan 5, 2026
59 of 60 checks passed
@RomneyDa RomneyDa deleted the dallin/relative-path-fallback-cli branch January 5, 2026 19:30
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jan 5, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants