fix handling of trailing commas in SecretStringSliceCSV.Set()#7587
Open
SungJin1212 wants to merge 1 commit into
Open
fix handling of trailing commas in SecretStringSliceCSV.Set()#7587SungJin1212 wants to merge 1 commit into
SungJin1212 wants to merge 1 commit into
Conversation
friedrichg
reviewed
Jun 4, 2026
SungJin1212
force-pushed
the
fix-SecretStringSliceCSV.Set()-trailing-comma
branch
2 times, most recently
from
2fa8e93 to
ff1bf4e
Compare
friedrichg
reviewed
Jun 17, 2026
friedrichg
reviewed
Jun 17, 2026
friedrichg
approved these changes
Jun 17, 2026
SungJin1212
force-pushed
the
fix-SecretStringSliceCSV.Set()-trailing-comma
branch
from
1e14520 to
8286eaf
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
fix-SecretStringSliceCSV.Set()-trailing-comma
branch
from
8286eaf to
9a29bc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes SecretStringSliceCSV.Set() to reject empty and whitespace-only entries caused by stray or trailing commas (e.g. newkey,, newkey,,oldkey).
Which issue(s) this PR fixes:
Fixes #7579
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags