perf(ring): cache ShuffleShardWithLookback subrings#7628
Open
afhassan wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ahmed Hassan <afayekhassan@gmail.com>
34d6007 to
2d60675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Add caching for
ShuffleShardWithLookbacksubrings. Previously, the shuffle shard lookback variantrecomputed on every call because its membership is time-dependent and could not be
represented by the existing topology-keyed cache.
New
ShuffleShardWithLookbackcacheA lookback subring's membership can only change for one of two reasons, and each is
covered by an invalidation path:
to/from
READONLY) — invalidates the entireshuffledSubringCachevialastTopologyChange.EqualButReadOnlyis treated as a topology change for thispurpose, so READONLY-driven inclusion changes are covered here.
shuffleShardrecordsshuffleShardExpiry = min(RegisteredTimestamp + lookbackPeriod)across all lookback-included instances on the subring.
getCachedShuffledSubringtreats the entry as a miss once
now >= shuffleShardExpiry, forcing a recompute.Implementation notes
subringCacheKeygainslookbackPeriodso lookback subrings don't collide withplain ones.
shuffleShardExpiry == 0andbehave like plain subrings (only topology invalidates).
Tests
Added
TestShuffleShardWithLookbackCachinginpkg/ring/ring_test.go, covering:timestamps refreshed on hit.
nowpastRegisteredTimestamp + lookbackPeriodforces a recompute andthe new subring shrinks (instances fall out of the window).
cached.
(user, size)are cached under separatekeys.
CleanupShuffleShardCacheevicts the entry.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags