Skip to content

Update corosio churn close() calls to match asio#133

Merged
mvandeberg merged 1 commit intocppalliance:developfrom
mvandeberg:chore/churn-close
Feb 11, 2026
Merged

Update corosio churn close() calls to match asio#133
mvandeberg merged 1 commit intocppalliance:developfrom
mvandeberg:chore/churn-close

Conversation

@mvandeberg
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • perf/bench/corosio/accept_churn_bench.cpp is excluded by !**/bench/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.81%. Comparing base (c98acaa) to head (f21d1cc).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #133      +/-   ##
===========================================
- Coverage    81.03%   80.81%   -0.22%     
===========================================
  Files           64       64              
  Lines         5557     5557              
===========================================
- Hits          4503     4491      -12     
- Misses        1054     1066      +12     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98acaa...f21d1cc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://133.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-02-11 22:56:00 UTC

@mvandeberg mvandeberg merged commit 08b2663 into cppalliance:develop Feb 11, 2026
17 checks passed
@mvandeberg mvandeberg deleted the chore/churn-close branch February 11, 2026 22:59
@cppalliance-bot
Copy link

GCOVR code coverage report https://133.corosio.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://133.corosio.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://133.corosio.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-02-11 23:02:20 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants