Update PRC fields and add placeholder for renderMethod images.#48
Draft
jameseaster wants to merge 1 commit intomainfrom
Draft
Update PRC fields and add placeholder for renderMethod images.#48jameseaster wants to merge 1 commit intomainfrom
jameseaster wants to merge 1 commit intomainfrom
Conversation
BigBlueHat
requested changes
Jul 10, 2024
Contributor
BigBlueHat
left a comment
BigBlueHat
left a comment
There was a problem hiding this comment.
Looks like I need to get updated SVGs for these.
Comment on lines
+4
to
+5
| "https://w3id.org/citizenship/v1", | ||
| "https://www.w3.org/ns/credentials/examples/v2" |
Contributor
There was a problem hiding this comment.
Suggested change
| "https://w3id.org/citizenship/v1", | |
| "https://www.w3.org/ns/credentials/examples/v2" | |
| "https://w3id.org/citizenship/v1", | |
| "https://www.w3.org/ns/credentials/examples/v2" |
Sneaking tab hiding in there.
Comment on lines
+35
to
+39
| "height": { | ||
| "type": "QuantitativeValue", | ||
| "unitCode": "INH", | ||
| "value": 65 | ||
| }, |
Contributor
There was a problem hiding this comment.
We probably need another formatter for height stuff.
Contributor
|
We also need to...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Add SVG images for renderMethod
Resolves update PRC example credential
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
NOTE: This uses the examples context instead of the appropriate context, because VC v2 and renderMethod are not yet stable.
Does this PR introduce a breaking change?
How has this been tested?
Screenshots: n/a