Utilize interior in relative scope modifier #3122
Open
+223
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@pokey Mind having a look at this? |
pokey
approved these changes
Dec 14, 2025
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Hard to say whether this will be nice or annoying in practice. I think worth shipping to find out
Comment on lines
+214
to
+216
| const interiorRanges = Array.from(interiorScopes) | ||
| .filter((s) => !s.domain.contains(initialPosition)) | ||
| .map((s) => s.domain); |
Member
There was a problem hiding this comment.
Nitpicking here but might as well do map / filter on the stream then convert to list at the end
| }, | ||
| ); | ||
|
|
||
| // Interiors containing the initial position are excluded |
Member
There was a problem hiding this comment.
Does this actually happen in practice? Prob no harm leaving it but I wouldn't expect it to actually happen
| return islice(scopes, offset - 1, offset + desiredScopeCount - 1); | ||
| } | ||
|
|
||
| function getInteriorRanges( |
Member
There was a problem hiding this comment.
Could use a jsdoc and a better name. Maybe like "getScopeInteriorRanges"? It's getting the top-level interior ranges for this scope right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By utilizing interior scope in relative scope modifier we can skip the interior of scopes. See new test.