-
Notifications
You must be signed in to change notification settings - Fork 1
Bump version to 0.1.0; modernize development environment #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b735d60
aa04d43
7edc159
01bff49
e866deb
e068f47
880bd73
d7873fe
c747ab1
c65edf8
5a8da0c
c6b8a3f
1688eba
1fc2506
9f4d991
22b9a98
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Lint | ||
|
|
||
| on: [push] | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: "3.10" | ||
| cache: 'pip' | ||
| cache-dependency-path: setup.py | ||
|
|
||
| - run: pip3 install -e '.[test]' | ||
| - run: make lint |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ build | |
| .idea/ | ||
| .python-version | ||
| venv | ||
| .venv | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| [env] | ||
| MISE_FETCH_REMOTE_VERSIONS_TIMEOUT = "30s" | ||
|
|
||
| _.python.venv = { | ||
| path = ".venv", | ||
| create = true, | ||
| } | ||
|
|
||
| [tools] | ||
| python = "3.9" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 3.9 is eol already should we bump up?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we should bump this one. |
||
|
|
||
| [tasks.test] | ||
| run = 'make install test' | ||
|
|
||
| [tasks.lint] | ||
| run = 'make install lint' | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| VERSION = '0.0.2' | ||
| VERSION = '0.1.0' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| backoff==2.2.1 | ||
| flake8==3.7.9 | ||
| monotonic==1.6 | ||
| mock==2.0.0 | ||
| pylint==3.3.3 | ||
| python-dateutil==2.8.2 | ||
| requests>=2.32.2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,15 +16,15 @@ | |
| ''' | ||
|
|
||
| install_requires = [ | ||
| "requests~=2.7", | ||
| "monotonic~=1.5", | ||
| "backoff~=2.1", | ||
| "python-dateutil~=2.2" | ||
| "requests>=2.32.2", | ||
| "monotonic~=1.6", | ||
| "backoff~=2.2", | ||
| "python-dateutil~=2.8" | ||
| ] | ||
|
|
||
| tests_require = [ | ||
| "mock==2.0.0", | ||
| "pylint==2.8.0", | ||
| "pylint>=3.2.0", | ||
| "flake8==3.7.9", | ||
| ] | ||
|
|
||
|
|
@@ -38,6 +38,7 @@ | |
| maintainer_email='cdp@customer.io', | ||
| test_suite='analytics.test.all', | ||
| packages=['customerio.analytics'], | ||
| # Newer versions are not tested with Python 3.6 or 3.7. | ||
| python_requires='>=3.6.0', | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this also be bumped up to min version we test against?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be a breaking change to bump the Python version here. If that's the case, I suggest we bump the package version to |
||
| license='MIT License', | ||
| install_requires=install_requires, | ||
|
|
@@ -52,9 +53,12 @@ | |
| "License :: OSI Approved :: MIT License", | ||
| "Operating System :: OS Independent", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3.6", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", | ||
| ], | ||
| ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like 3.8 & 3.9 are also eol https://endoflife.date/python should we remove those as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would keep these for now, since they are still available in GitHub runners.