Fix: Improvements to card swipe animations and gesture handling#14
Merged
dadalar merged 4 commits intodadalar:masterfrom Feb 11, 2025
Merged
Conversation
Ensured the card being swiped is always above the stack during dismissal animation by managing zIndex.
Disabled interactions with clickable elements (e.g., buttons) on cards while swiping to prevent unintended actions caused by simultaneous gestures.
Fixed an issue causing debug errors during rapid swipes due to improper synchronization of translation animation states: Invalid sample AnimatablePair<AnimatablePair<CGFloat, CGFloat>, AnimatablePair<CGFloat, CGFloat>>(first: SwiftUI.AnimatablePair<CoreGraphics.CGFloat, CoreGraphics.CGFloat>(first: -2.0, second: 0.0), second: SwiftUI.AnimatablePair<CoreGraphics.CGFloat, CoreGraphics.CGFloat>(first: 0.0, second: 0.0)) with time Time(seconds: 0.0) > last time Time(seconds: 0.016671041666995734)
…her gesture Ensured proper gesture state reset to avoid cards being stuck in an intermediate position when DragGesture is interrupted by another gesture. For example, if a second finger taps the card during a swipe, the onEnded callback now triggers correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple issues with animations and gestures in CardStackView: