Skip to content

[Backport release-1.18] Add support for workflow history propagation#1751

Merged
siri-varma merged 1 commit into
release-1.18from
backport-1739-to-release-1.18
May 22, 2026
Merged

[Backport release-1.18] Add support for workflow history propagation#1751
siri-varma merged 1 commit into
release-1.18from
backport-1739-to-release-1.18

Conversation

@dapr-bot
Copy link
Copy Markdown
Collaborator

Backport d87a84c from #1739.

* Apply suggestions from code review

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Refactor BookTripWorkflow to use CompensationHelper

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Add CompensationHelper class for managing compensations

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Await cancellation activities in BookTripWorkflow

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Add the new changes

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* fix violations

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Fix helper

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Modify readme

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Modify readme

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Modify readme

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Update copyright year and improve comment clarity

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Update copyright year to 2026

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Update HistoryPropagationScope.java

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Update ActivityHistoryPropagationTest.java

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Change to 2026

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Fix things

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Potential fix for pull request finding

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Hide chunk concept; expose WorkflowResult with typed lookups

Address review feedback on #1739: replace user-facing PropagatedHistoryChunk
with WorkflowResult, mirroring dapr/durabletask-go#105. Adds typed
ActivityResult and ChildWorkflowResult value types, and getLast*ByName /
get*ByName lookups so callers don't walk raw history events. Renames
getWorkflowByName to getLastWorkflowByName for symmetry with the new
methods.

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Bump copyright year to 2026 on PR files

Address review feedback (#1739): the new files in this PR were stamped
2025 - update them to 2026 to match the year the work is landing.

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Surface PropagatedHistoryException at parse boundaries

Address review feedback (#1739):

- TaskOrchestrationExecutor.execute: catch PropagatedHistoryException
  ahead of the generic Exception branch so a malformed payload is
  logged as a parse failure (not just "unhandled exception") before
  failing the context.
- TaskActivityExecutor.execute: wrap PropagatedHistory.fromProto in a
  try/catch and rethrow PropagatedHistoryException with the activity
  name in the message, so the caller sees a typed parse failure
  rather than something that looks like a generic protobuf error.

Adds tests for both paths driving a malformed PropagatedHistory chunk
through each executor.

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

* Address comments

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>

---------

Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
(cherry picked from commit d87a84c)
@dapr-bot dapr-bot requested review from a team as code owners May 22, 2026 00:20
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.90%. Comparing base (7616981) to head (c93e095).

Files with missing lines Patch % Lines
...kflows/runtime/DefaultWorkflowActivityContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release-1.18    #1751      +/-   ##
==================================================
+ Coverage           76.88%   76.90%   +0.01%     
- Complexity           2287     2293       +6     
==================================================
  Files                 243      243              
  Lines                7107     7117      +10     
  Branches              745      745              
==================================================
+ Hits                 5464     5473       +9     
- Misses               1278     1279       +1     
  Partials              365      365              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siri-varma siri-varma merged commit d5a9f74 into release-1.18 May 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants