Skip to content

Alternative simple yesno#20138

Merged
TurboGit merged 3 commits intodarktable-org:masterfrom
jenshannoschwalm:alternative_simple_yesno
Feb 7, 2026
Merged

Alternative simple yesno#20138
TurboGit merged 3 commits intodarktable-org:masterfrom
jenshannoschwalm:alternative_simple_yesno

Conversation

@jenshannoschwalm
Copy link
Copy Markdown
Collaborator

In a lot of cases we report "YES"/"NO" or "TRUE"/"FALSE", introduce two macros for code density.
Second commit makes use of those

@jenshannoschwalm jenshannoschwalm added the scope: codebase making darktable source code easier to manage label Jan 12, 2026
@jenshannoschwalm jenshannoschwalm added this to the 5.6 milestone Jan 12, 2026
@TurboGit
Copy link
Copy Markdown
Member

I was about to propose that while reading your previous PR. Nice!

@jenshannoschwalm
Copy link
Copy Markdown
Collaborator Author

@TurboGit is is possible to cherry pick and merge at least the first commit introducing the macros now?

@jenshannoschwalm jenshannoschwalm force-pushed the alternative_simple_yesno branch 2 times, most recently from eab66dd to acf3748 Compare January 13, 2026 10:33
@jenshannoschwalm
Copy link
Copy Markdown
Collaborator Author

Added all opencl related log changes to this PR ...

@TurboGit
Copy link
Copy Markdown
Member

@TurboGit is is possible to cherry pick and merge at least the first commit introducing the macros now?

Yes I can do that.

@jenshannoschwalm
Copy link
Copy Markdown
Collaborator Author

Yes I can do that.

I reworked the different PR's a bit and now here is all related logging stuff. So no need to do so ...

@jenshannoschwalm jenshannoschwalm force-pushed the alternative_simple_yesno branch 3 times, most recently from feae92d to ec4469b Compare January 29, 2026 07:36
In a lot of cases we report "YES"/"NO" or "TRUE"/"FALSE", introduce two macros for code density
Using `STR_TRUEFALSE` and `STR_YESNO`
- consequently use the nts dt_print() variant for better formatting
- avoid showing build logs if there isn't any or too long
@jenshannoschwalm jenshannoschwalm force-pushed the alternative_simple_yesno branch from ec4469b to 310d0f6 Compare February 3, 2026 12:55
Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit c148595 into darktable-org:master Feb 7, 2026
5 checks passed
@jenshannoschwalm jenshannoschwalm deleted the alternative_simple_yesno branch February 7, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: codebase making darktable source code easier to manage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants