-
Notifications
You must be signed in to change notification settings - Fork 1
test: add Playwright integration tests for dev-playground #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
calvarjorge
wants to merge
6
commits into
main
Choose a base branch
from
jorge.calvar/add_integration_tests_locally
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3bd97f8
test: add Playwright integration tests for dev-playground
calvarjorge a9f7795
test: apply PR feedback - remove unnecessary tests and reorganize utils
calvarjorge 0643065
Merge remote-tracking branch 'origin/main' into jorge.calvar/add_inte…
calvarjorge 42893a8
refactor: simplify test navigation by using goto waitUntil option
calvarjorge 3fd2b21
test: update playwright version
calvarjorge 095c048
ci: add playground integration tests job (#88)
calvarjorge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Playwright | ||
| test-results/ | ||
| playwright-report/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Dev Playground | ||
|
|
||
| Test application showing AppKit capabilities including analytics dashboards, SSE streaming, telemetry, and data visualization. | ||
|
|
||
| ## Development | ||
|
|
||
| ```bash | ||
| # Start development server | ||
| pnpm dev | ||
|
|
||
| # Build for production | ||
| pnpm build | ||
|
|
||
| # Start production server | ||
| pnpm start:local | ||
| ``` | ||
|
|
||
| ## Integration Tests | ||
|
|
||
| Integration tests use Playwright to verify the application works correctly with mocked backend responses. | ||
|
|
||
| **Note:** These are frontend-only integration tests. API calls are intercepted at the browser level and return mock data, so the AppKit backend plugins are not tested. They focus on verifying UI behavior, navigation, data rendering, and client-side interactions. | ||
|
|
||
| ### Running Tests | ||
|
|
||
| ```bash | ||
| # Run all integration tests | ||
| pnpm test:integration | ||
|
|
||
| # Run tests with interactive UI mode (for debugging) | ||
| pnpm test:integration:ui | ||
|
|
||
| # Run tests in headed mode (see the browser) | ||
| pnpm test:integration:headed | ||
|
|
||
| # Run a specific test file | ||
| npx playwright test tests/smoke.spec.ts | ||
|
|
||
| # Run tests matching a pattern | ||
| npx playwright test -g "analytics" | ||
| ``` | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { defineConfig, devices } from "@playwright/test"; | ||
|
|
||
| export default defineConfig({ | ||
| testDir: "./tests", | ||
| fullyParallel: true, | ||
| forbidOnly: !!process.env.CI, | ||
| retries: 0, | ||
| workers: process.env.CI ? 1 : undefined, | ||
| reporter: "html", | ||
| use: { | ||
| baseURL: "http://localhost:8000", | ||
| trace: "on-first-retry", | ||
| }, | ||
| projects: [ | ||
| { | ||
| name: "chromium", | ||
| use: { ...devices["Desktop Chrome"] }, | ||
| }, | ||
| ], | ||
| webServer: { | ||
| command: "pnpm dev", | ||
| url: "http://localhost:8000", | ||
| reuseExistingServer: !process.env.CI, | ||
| timeout: 120 * 1000, | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a note to ensure the
DATABRICKS_APP_PORTis not overriden in the.envfile - as initially running those tests failed in my case because of that reason.EDIT: We specify
DATABRICKS_APP_PORT=8001in the.env.distso after all maybe we should adjust the default test configuration to point to the app running on 8001 port?JFYI - we specify it to avoid collision with the clean app example and run
pnpm devon the root ofappkitrepo to run all the apps.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calvarjorge I think you missed that PR, PTAL - let's configure playwright to point to the app working on 8001 port as our
.env.distconfigures, alright?