-
Notifications
You must be signed in to change notification settings - Fork 127
pipelines: use lakeflow-pipelines template #4237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kanterov
wants to merge
1
commit into
main
Choose a base branch
from
pipelines-cli-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f111da to
6c12108
Compare
Collaborator
|
Commit: 6c12108
25 interesting tests: 17 KNOWN, 7 RECOVERED, 1 SKIP
Top 32 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change template in "pipelines init" from "cli-pipelines" to "lakeflow-pipelines".
Remove the code for "cli-pipelines" template and point "cli-pipelines" template into "lakeflow-pipelines" in case anything relies on undocumented hidden template.
There are a few minor problems with lakeflow-pipelines template that we will address in a follow-up. For example, we create job parameters, but never use them.
Why
lakeflow-pipelines template follows recommended layout for SDP projects in DABs and is consistent with how other templates are structured.
Tests
Updated acceptance tests