Skip to content

Comments

Display plugin setup instructions after apps init flow, remove empty files after template rendering#4549

Open
pkosiec wants to merge 8 commits intomainfrom
pkosiec/rm-hardcoded-plugin-paths
Open

Display plugin setup instructions after apps init flow, remove empty files after template rendering#4549
pkosiec wants to merge 8 commits intomainfrom
pkosiec/rm-hardcoded-plugin-paths

Conversation

@pkosiec
Copy link
Member

@pkosiec pkosiec commented Feb 19, 2026 •
edited
Loading

Changes

  • Show setup notes for plugins which have such instructions (needed for Lakebase plugin temporarily)
  • Remove hardcoded paths for analytics plugin - this will be handled purely by Go templates in the template itself
  • Remove empty files and directories after template rendering
  • Setup listers for postgres resource
  • Run "postinit" npm command in context of template if it exists - reverted as we don't need it for now

Those changes need to be synchronized with AppKit where we add the templatePaths property in the manifest.

Why

See also https://databricks.atlassian.net/browse/LKB-9681

Screenshot

image

Demo

(just the listers for future Lakebase plugin changes databricks/appkit#132)

Screen.Recording.2026-02-24.at.15.43.45.mov

@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Feb 19, 2026 •
edited
Loading

Commit: 17fd2f5

Run: 22355988075

Env 🟨​KNOWN 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
🟨​ aws linux 7 1 7 268 763 7:03
🟨​ aws windows 7 1 7 270 761 6:39
💚​ aws-ucws linux 8 7 364 679 6:36
💚​ aws-ucws windows 8 7 366 677 5:15
💚​ azure linux 2 9 271 761 5:45
💚​ azure windows 2 9 273 759 4:54
💚​ azure-ucws linux 2 9 369 675 7:22
💚​ azure-ucws windows 2 9 371 673 6:47
💚​ gcp linux 2 9 267 764 5:10
💚​ gcp windows 2 9 269 762 5:36
15 interesting tests: 7 KNOWN, 7 SKIP, 1 RECOVERED
Test Name aws linux aws windows aws-ucws linux aws-ucws windows azure linux azure windows azure-ucws linux azure-ucws windows gcp linux gcp windows
🟨​ TestAccept 🟨​K 🟨​K 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/resources/permissions 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions 🟨​K 🟨​K 💚​R 💚​R 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct 🟨​K 🟨​K 💚​R 💚​R
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform 🟨​K 🟨​K 💚​R 💚​R
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions 🟨​K 🟨​K 💚​R 💚​R 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct 🟨​K 🟨​K 💚​R 💚​R
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform 🟨​K 🟨​K 💚​R 💚​R
🙈​ TestAccept/bundle/resources/postgres_branches/basic 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/recreate 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/update_protected 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/without_branch_id 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_endpoints/recreate 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/synced_database_tables/basic 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
💚​ TestAccept/ssh/connection 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 20 slowest tests (at least 2 minutes):
duration env testname
3:38 gcp windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:25 azure-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:14 gcp linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:12 gcp windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:10 azure-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:09 gcp linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:02 aws-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:00 aws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:00 aws-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:56 azure-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:54 aws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:53 aws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:52 aws-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:48 aws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:45 aws-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:18 azure-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:13 azure linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:11 azure windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:08 azure windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:08 azure linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct

@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from be69f43 to 4814591 Compare February 20, 2026 09:52
@pkosiec pkosiec changed the title Read plugin-owned paths from manifest during the apps init Run a postinit template command after apps init flow Feb 20, 2026
@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from f568792 to 6f37920 Compare February 23, 2026 12:47
@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from 6f37920 to b0d7806 Compare February 23, 2026 16:50
@pkosiec pkosiec changed the title Run a postinit template command after apps init flow Display plugin setup instructions after apps init flow Feb 23, 2026
@pkosiec pkosiec changed the title Display plugin setup instructions after apps init flow Display plugin setup instructions after apps init flow, remove hardcoded plugin paths Feb 23, 2026
@pkosiec pkosiec changed the title Display plugin setup instructions after apps init flow, remove hardcoded plugin paths Display plugin setup instructions after apps init flow Feb 23, 2026
@pkosiec pkosiec changed the title Display plugin setup instructions after apps init flow Display plugin setup instructions after apps init flow, remove empty files after template rendering Feb 23, 2026
@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from 4218939 to ba9c6f2 Compare February 23, 2026 16:59
@pkosiec pkosiec marked this pull request as ready for review February 23, 2026 17:00
@pkosiec pkosiec requested a review from a team as a code owner February 23, 2026 17:00
This was referenced Feb 23, 2026
Open
Open
Draft
@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from ba9c6f2 to 17fd2f5 Compare February 24, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pkosiec @eng-dev-ecosystem-bot