Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codegen/_openapi_sha
Original file line number Diff line number Diff line change
@@ -1 +1 @@
281b4455821119945fcc4c850cf2cfad03e23c6c
d91ff2db7c9265e784ceac0de2059f3e5fada8c5
2 changes: 2 additions & 0 deletions NEXT_CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
## Release v0.290.0

### Internal:

### API Changes
20 changes: 20 additions & 0 deletions acceptance/bundle/refschema/out.fields.txt
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ resources.apps.*.permissions[*].service_principal_name string INPUT
resources.apps.*.permissions[*].user_name string INPUT
resources.apps.*.resources []apps.AppResource ALL
resources.apps.*.resources[*] apps.AppResource ALL
resources.apps.*.resources[*].app *apps.AppResourceApp ALL
resources.apps.*.resources[*].database *apps.AppResourceDatabase ALL
resources.apps.*.resources[*].database.database_name string ALL
resources.apps.*.resources[*].database.instance_name string ALL
Expand Down Expand Up @@ -191,6 +192,7 @@ resources.apps.*.resources[*].sql_warehouse.permission apps.AppResourceSqlWareho
resources.apps.*.resources[*].uc_securable *apps.AppResourceUcSecurable ALL
resources.apps.*.resources[*].uc_securable.permission apps.AppResourceUcSecurableUcSecurablePermission ALL
resources.apps.*.resources[*].uc_securable.securable_full_name string ALL
resources.apps.*.resources[*].uc_securable.securable_kind string ALL
resources.apps.*.resources[*].uc_securable.securable_type apps.AppResourceUcSecurableUcSecurableType ALL
resources.apps.*.service_principal_client_id string ALL
resources.apps.*.service_principal_id int64 ALL
Expand Down Expand Up @@ -2541,6 +2543,10 @@ resources.postgres_endpoints.*.create_time *time.Time REMOTE
resources.postgres_endpoints.*.disabled bool INPUT STATE
resources.postgres_endpoints.*.endpoint_id string INPUT STATE
resources.postgres_endpoints.*.endpoint_type postgres.EndpointType INPUT STATE
resources.postgres_endpoints.*.group *postgres.EndpointGroupSpec INPUT STATE
resources.postgres_endpoints.*.group.enable_readable_secondaries bool INPUT STATE
resources.postgres_endpoints.*.group.max int INPUT STATE
resources.postgres_endpoints.*.group.min int INPUT STATE
resources.postgres_endpoints.*.id string INPUT
resources.postgres_endpoints.*.lifecycle resources.Lifecycle INPUT
resources.postgres_endpoints.*.lifecycle.prevent_destroy bool INPUT
Expand All @@ -2556,6 +2562,10 @@ resources.postgres_endpoints.*.spec.autoscaling_limit_max_cu float64 REMOTE
resources.postgres_endpoints.*.spec.autoscaling_limit_min_cu float64 REMOTE
resources.postgres_endpoints.*.spec.disabled bool REMOTE
resources.postgres_endpoints.*.spec.endpoint_type postgres.EndpointType REMOTE
resources.postgres_endpoints.*.spec.group *postgres.EndpointGroupSpec REMOTE
resources.postgres_endpoints.*.spec.group.enable_readable_secondaries bool REMOTE
resources.postgres_endpoints.*.spec.group.max int REMOTE
resources.postgres_endpoints.*.spec.group.min int REMOTE
resources.postgres_endpoints.*.spec.no_suspension bool REMOTE
resources.postgres_endpoints.*.spec.settings *postgres.EndpointSettings REMOTE
resources.postgres_endpoints.*.spec.settings.pg_settings map[string]string REMOTE
Expand All @@ -2567,8 +2577,13 @@ resources.postgres_endpoints.*.status.autoscaling_limit_min_cu float64 REMOTE
resources.postgres_endpoints.*.status.current_state postgres.EndpointStatusState REMOTE
resources.postgres_endpoints.*.status.disabled bool REMOTE
resources.postgres_endpoints.*.status.endpoint_type postgres.EndpointType REMOTE
resources.postgres_endpoints.*.status.group *postgres.EndpointGroupStatus REMOTE
resources.postgres_endpoints.*.status.group.enable_readable_secondaries bool REMOTE
resources.postgres_endpoints.*.status.group.max int REMOTE
resources.postgres_endpoints.*.status.group.min int REMOTE
resources.postgres_endpoints.*.status.hosts *postgres.EndpointHosts REMOTE
resources.postgres_endpoints.*.status.hosts.host string REMOTE
resources.postgres_endpoints.*.status.hosts.read_only_host string REMOTE
resources.postgres_endpoints.*.status.pending_state postgres.EndpointStatusState REMOTE
resources.postgres_endpoints.*.status.settings *postgres.EndpointSettings REMOTE
resources.postgres_endpoints.*.status.settings.pg_settings map[string]string REMOTE
Expand All @@ -2594,6 +2609,11 @@ resources.postgres_projects.*.default_endpoint_settings.suspend_timeout_duration
resources.postgres_projects.*.display_name string INPUT STATE
resources.postgres_projects.*.history_retention_duration *duration.Duration INPUT STATE
resources.postgres_projects.*.id string INPUT
resources.postgres_projects.*.initial_endpoint_spec *postgres.InitialEndpointSpec REMOTE
resources.postgres_projects.*.initial_endpoint_spec.group *postgres.EndpointGroupSpec REMOTE
resources.postgres_projects.*.initial_endpoint_spec.group.enable_readable_secondaries bool REMOTE
resources.postgres_projects.*.initial_endpoint_spec.group.max int REMOTE
resources.postgres_projects.*.initial_endpoint_spec.group.min int REMOTE
resources.postgres_projects.*.lifecycle resources.Lifecycle INPUT
resources.postgres_projects.*.lifecycle.prevent_destroy bool INPUT
resources.postgres_projects.*.modified_status string INPUT
Expand Down
1 change: 1 addition & 0 deletions acceptance/cmd/account/account-help/output.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Settings
Provisioning
credentials These APIs manage credential configurations for this workspace.
encryption-keys These APIs manage encryption key configurations for this workspace (optional).
endpoints These APIs manage endpoint configurations for this account.
networks These APIs manage network configurations for customer-managed VPCs (optional).
private-access These APIs manage private access settings for this account.
storage These APIs manage storage configurations for this workspace.
Expand Down
1 change: 1 addition & 0 deletions bundle/direct/dresources/postgres_endpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ func (*ResourcePostgresEndpoint) RemapState(remote *postgres.Endpoint) *Postgres
AutoscalingLimitMinCu: 0,
Disabled: false,
EndpointType: "",
Group: nil,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual fix: New Group field added in SDK v0.111.0 for postgres.EndpointSpec. Added here to satisfy exhaustruct linter — the struct literal must initialize all fields.

NoSuspension: false,
Settings: nil,
SuspendTimeoutDuration: nil,
Expand Down
6 changes: 4 additions & 2 deletions bundle/direct/dresources/postgres_project.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ func (r *ResourcePostgresProject) DoCreate(ctx context.Context, config *Postgres
waiter, err := r.client.Postgres.CreateProject(ctx, postgres.CreateProjectRequest{
ProjectId: config.ProjectId,
Project: postgres.Project{
Spec: &config.ProjectSpec,
Spec: &config.ProjectSpec,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual fix: New InitialEndpointSpec field added in SDK v0.111.0 for postgres.Project. Set to nil in both DoCreate and DoUpdate to satisfy exhaustruct linter.

InitialEndpointSpec: nil,

// Output-only fields.
CreateTime: nil,
Expand Down Expand Up @@ -90,7 +91,8 @@ func (r *ResourcePostgresProject) DoUpdate(ctx context.Context, id string, confi

waiter, err := r.client.Postgres.UpdateProject(ctx, postgres.UpdateProjectRequest{
Project: postgres.Project{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual fix: Same InitialEndpointSpec exhaustruct fix as above, this time in DoUpdate.

Spec: &config.ProjectSpec,
Spec: &config.ProjectSpec,
InitialEndpointSpec: nil,

// Output-only fields.
CreateTime: nil,
Expand Down
6 changes: 6 additions & 0 deletions bundle/direct/dresources/resources.generated.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ resources:
external_locations:

ignore_remote_changes:
- field: effective_enable_file_events
reason: spec:output_only
- field: file_event_queue.managed_aqs.managed_resource_id
reason: spec:output_only
- field: file_event_queue.managed_pubsub.managed_resource_id
Expand Down Expand Up @@ -237,6 +239,10 @@ resources:
reason: spec:immutable

ignore_remote_changes:
- field: budget_policy_id
reason: spec:input_only
- field: custom_tags
reason: spec:input_only
- field: default_endpoint_settings
reason: spec:input_only
- field: display_name
Expand Down
1 change: 1 addition & 0 deletions bundle/direct/dresources/type_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ var knownMissingInRemoteType = map[string][]string{
"disabled",
"endpoint_id",
"endpoint_type",
"group",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual fix: Added group to knownMissingInRemoteType for postgres_endpoints — mirrors the new Group field in EndpointSpec that isn't present in the remote type mapping.

"no_suspension",
"settings",
"suspend_timeout_duration",
Expand Down
3 changes: 3 additions & 0 deletions bundle/internal/schema/annotations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -893,6 +893,9 @@ github.com/databricks/cli/bundle/config/resources.PostgresEndpoint:
"endpoint_type":
"description": |-
PLACEHOLDER
"group":
"description": |-
PLACEHOLDER
"lifecycle":
"description": |-
PLACEHOLDER
Expand Down
30 changes: 29 additions & 1 deletion bundle/internal/schema/annotations_openapi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,7 @@ github.com/databricks/cli/bundle/config/resources.SqlWarehouse:
"description": |-
Configures whether the warehouse should use Photon optimized clusters.

Defaults to false.
Defaults to true.
"enable_serverless_compute":
"description": |-
Configures whether the warehouse should use serverless compute
Expand Down Expand Up @@ -1222,6 +1222,9 @@ github.com/databricks/databricks-sdk-go/service/apps.AppDeploymentStatus:
"x-databricks-field-behaviors_output_only": |-
true
github.com/databricks/databricks-sdk-go/service/apps.AppResource:
"app":
"x-databricks-preview": |-
PRIVATE
"database": {}
"description":
"description": |-
Expand All @@ -1236,6 +1239,7 @@ github.com/databricks/databricks-sdk-go/service/apps.AppResource:
"serving_endpoint": {}
"sql_warehouse": {}
"uc_securable": {}
github.com/databricks/databricks-sdk-go/service/apps.AppResourceApp: {}
github.com/databricks/databricks-sdk-go/service/apps.AppResourceDatabase:
"database_name": {}
"instance_name": {}
Expand Down Expand Up @@ -1346,6 +1350,14 @@ github.com/databricks/databricks-sdk-go/service/apps.AppResourceSqlWarehouseSqlW
github.com/databricks/databricks-sdk-go/service/apps.AppResourceUcSecurable:
"permission": {}
"securable_full_name": {}
"securable_kind":
"description": |-
The securable kind from Unity Catalog.
See https://docs.databricks.com/api/workspace/tables/get#securable_kind_manifest-securable_kind.
"x-databricks-field-behaviors_output_only": |-
true
"x-databricks-preview": |-
PRIVATE
"securable_type": {}
github.com/databricks/databricks-sdk-go/service/apps.AppResourceUcSecurableUcSecurablePermission:
"_":
Expand All @@ -1360,6 +1372,8 @@ github.com/databricks/databricks-sdk-go/service/apps.AppResourceUcSecurableUcSec
EXECUTE
- |-
USE_CONNECTION
- |-
MODIFY
github.com/databricks/databricks-sdk-go/service/apps.AppResourceUcSecurableUcSecurableType:
"_":
"enum":
Expand Down Expand Up @@ -4658,6 +4672,20 @@ github.com/databricks/databricks-sdk-go/service/pipelines.TableSpecificConfigScd
SCD_TYPE_2
- |-
APPEND_ONLY
github.com/databricks/databricks-sdk-go/service/postgres.EndpointGroupSpec:
"enable_readable_secondaries":
"description": |-
Whether to allow read-only connections to read-write endpoints. Only relevant for read-write endpoints where
size.max > 1.
"max":
"description": |-
The maximum number of computes in the endpoint group. Currently, this must be equal to min. Set to 1 for single
compute endpoints, to disable HA. To manually suspend all computes in an endpoint group, set disabled to
true on the EndpointSpec.
"min":
"description": |-
The minimum number of computes in the endpoint group. Currently, this must be equal to max. This must be greater
than or equal to 1.
github.com/databricks/databricks-sdk-go/service/postgres.EndpointSettings:
"_":
"description": |-
Expand Down
3 changes: 3 additions & 0 deletions bundle/internal/schema/annotations_openapi_overrides.yml
Original file line number Diff line number Diff line change
Expand Up @@ -774,6 +774,9 @@ github.com/databricks/databricks-sdk-go/service/apps.AppDeploymentStatus:
"description": |-
PLACEHOLDER
github.com/databricks/databricks-sdk-go/service/apps.AppResource:
"app":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual fix: Added app PLACEHOLDER entry for the new AppResource.App field introduced in this SDK version. Needed because annotations.yml generation added it but the overrides file needs a corresponding entry.

"description": |-
PLACEHOLDER
"database":
"description": |-
PLACEHOLDER
Expand Down
2 changes: 1 addition & 1 deletion bundle/internal/validation/generated/enum_fields.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion bundle/internal/validation/generated/required_fields.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

53 changes: 52 additions & 1 deletion bundle/schema/jsonschema.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading