fix: more locations with .designer.ipynb extension stripping#5656
Open
artchen-db wants to merge 2 commits into
Open
fix: more locations with .designer.ipynb extension stripping#5656artchen-db wants to merge 2 commits into
artchen-db wants to merge 2 commits into
Conversation
Lakeflow Designer notebooks are stored in the workspace as DESIGNER_FILE objects with a compound ".designer.ipynb" extension. Several call sites stripped notebook extensions with path.Ext + TrimSuffix, which removed only the trailing ".ipynb" and left an orphaned ".designer", producing a path that no longer round-trips on deploy/import. Route these sites through the existing notebook.StripExtension helper, which preserves the ".designer.ipynb" suffix: - bundle/generate/downloader.go (the reported `bundle generate` bug). Also download Designer files as Jupyter notebooks, since get-status reports no export format for them. The export format is now selected generically via a new notebook.FixedExportFormat(objectType) lookup keyed on the object type rather than a designer-specific check. - libs/sync/snapshot_state.go, which otherwise tracked Designer notebooks at the wrong remote name, inconsistent with translate_paths. - cmd/workspace/workspace/import_dir.go (logged remote path). Co-authored-by: Isaac
artchen-db
changed the title
andrewnester
approved these changes
Jun 19, 2026
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
testifylint's go-require rule forbids require inside HTTP handlers since require's FailNow is only safe in the test goroutine. Co-authored-by: Isaac
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lakeflow Designer notebooks are stored as
DESIGNER_FILEobjects with a compound.designer.ipynbextension. Several CLI sites stripped notebook extensions withpath.Ext+TrimSuffix, removing only the trailing.ipynband leaving an orphaned.designer— a path that no longer round-trips on deploy/import. This routes them through the existingnotebook.StripExtensionhelper, which preserves the suffix. (Originally reported forbundle generateof a job referencing a Designer notebook.)Key changes
bundle/generate/downloader.go— the reported bug; preserve the suffix and download Designer files as Jupyter (get-status reports no export format for them).libs/notebook/ext.go— addObjectTypeDesignerFile+FixedExportFormat(objectType), so the format override is keyed generically on object type rather than a designer-specific check.libs/sync/snapshot_state.go— sync otherwise tracked Designer notebooks at the wrong remote name, inconsistent withtranslate_paths.cmd/workspace/workspace/import_dir.go— logged remote path for imported Designer notebooks.Notes
export_dir.go,configsync/resolve.go, filer extensions client,detect.go): already correct — Designer objects keep their full name and aren'tNOTEBOOK-typed, so they round-trip as regular files.TestFixedExportFormat,TestDownloader_MarkTasksForDownload_DesignerNotebook, a sync fixture, and an end-to-endacceptance/bundle/generate/designer_job/test.