Ignore output-only fields via ignore_remote_changes instead of zeroing#5678
Merged
Conversation
dashboard and registered_model RemapState zeroed output-only fields (create_time, update_time, etc.) to hide them from diff computation. Carry the real remote values through and rely on ignore_remote_changes instead, which already covers them (generated config for dashboard, resources.yml for registered_model). Co-authored-by: Isaac
Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 957a5c9
|
shreyas-goenka
approved these changes
Jun 22, 2026
DoUpdate's return value feeds reference resolution (RemoteStateCache), not diffing. It was zeroing creation_timestamp, last_updated_timestamp, latest_versions, and user_id even though the UpdateModel response provides them, so references resolved to empty until the next DoRead. Carry those through; only Id and PermissionLevel stay empty since ml.Model does not include them. Add nil guards on the response. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dashboardandregistered_modelRemapStatezeroed out output-only fields (create_time,update_time,created_at, etc.) so they wouldn't show up in diff computation. This discards the real remote value and duplicates suppression logic.Carry the real remote values through and rely on
ignore_remote_changesinstead:resources.generated.yml(OpenAPIoutput_onlyannotations)resources.ymlAdded a
RULEtodresources/README.mddocumenting this. Regenerated acceptance outputs — the fields now appear asskip / output_onlyinstead of being hidden. Verified with the invariant idempotency test and full acceptance suite.This pull request and its description were written by Isaac.