Pin Maven Dependencies to SHAs via Lockfile#739
Merged
hectorcast-db merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
parthban-db
reviewed
Mar 26, 2026
| { | ||
| "artifactId": "databricks-sdk-parent", | ||
| "groupId": "com.databricks", | ||
| "version": "0.103.0", |
Contributor
There was a problem hiding this comment.
We need to upgrade the tagging or some script to update this; otherwise, we can forget to update this.
| { | ||
| "artifactId": "databricks-sdk-java", | ||
| "groupId": "com.databricks", | ||
| "version": "0.103.0", |
pietern
approved these changes
Mar 27, 2026
| uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0 | ||
|
|
||
| - name: Validate lockfile | ||
| run: make check-lock |
Contributor
There was a problem hiding this comment.
We should run this prior to the release as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds SHA-256 hash verification for all Maven dependencies using the
maven-lockfile plugin.
This is the Maven equivalent of Go's go.sum or pip's --require-hashes.
Maven's default checksum policy is permissive (warns on mismatch but doesn't
fail). The lockfile plugin generates a committed
lockfile.jsonwith SHA-256hashes for every dependency (direct + transitive) and validates them in CI.
Changes:
maven-lockfileplugin (v5.5.2) to rootpom.xmllockfile.jsonfor both parent and SDK modulescheck-lockjob topush.ymlthat validates on every PRmake lock/make check-locktargetsTo update after dependency changes: run
make lockand commit the updatedlockfile(s).