[PECOBLR-330] Support for complex params#559
Conversation
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
3026b6f to
37c89b8
Compare
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
| class ParamEscaper: | ||
| _DATE_FORMAT = "%Y-%m-%d" | ||
| _TIME_FORMAT = "%H:%M:%S.%f" | ||
| _TIME_FORMAT = "%H:%M:%S.%f %z" |
There was a problem hiding this comment.
Timezone will not be there for TIMESTAMP_NTZ param.
There was a problem hiding this comment.
+1, would like to know how we've accounted/tested for NTZ
There was a problem hiding this comment.
If it is not there it will be an empty space, there is already a test suite that inserts NTZ and none NTZ and reads back to compare whether it is equal or not
There was a problem hiding this comment.
@vikrantpuppala @shivam2680 There are already existing tests that insert NTZ and non NTZ values and reads back from table to ensure everything is working as expected -
| class ParamEscaper: | ||
| _DATE_FORMAT = "%Y-%m-%d" | ||
| _TIME_FORMAT = "%H:%M:%S.%f" | ||
| _TIME_FORMAT = "%H:%M:%S.%f %z" |
There was a problem hiding this comment.
+1, would like to know how we've accounted/tested for NTZ
gopalldb
left a comment
There was a problem hiding this comment.
Is this not an opt-in feature, can't user disable this in favor of existing behavior?
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
@gopalldb We are just adding support for more types, don't think there is anything to opt in. If the users don't use complex types they won't need this |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Description
This PR introduces comprehensive support for complex parameter types (
ARRAYandMAP) in the Databricks SQL Python client.Key Changes
ArrayParameterandMapParameterdbsql_parameter_from_primitiveis updated to recognize and construct these parameter types, including for nested complex values.TSparkParamValueArgswhich is necessary to be passed as arguements for complex typesTesting
e2e
ARRAY<ARRAY<STRING>>, ARRAY<MAP<STRING,INTEGER>>, MAP<STRING,ARRAY<STRING>>unit