Fix show bundle logs in Cursor - #2093
Open
misha-db wants to merge 2 commits into
Open
Conversation
Contributor
|
🤖 Integration tests ✅ all 35 test jobs passed for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Problem
LoggerManager.showOutputChannel() called LogOutputChannel.show(), which silently did nothing on hosts that register a log channel under a different id than the extension host derives for it. The extension host computes the channel id locally (.) and never round-trips it through the workbench, so the two can disagree — some hosts append a workspace scope segment (.workspaceId-). When they disagree, .show() targets an id that isn't registered and the channel never appears.
User-visible effect: Databricks: Show Bundle Logs (databricks.bundle.showLogs), the databricks.internal.showOutput command behind the AI-tools "Show Logs" affordance, and the "Show Error Logs" button in CliWrapper's error notification all appeared to do nothing.
Fix
New src/logger/outputChannelReveal.ts recovers the real reveal command by probing the registered command list for workbench.action.output.show.:
This is a capability probe rather than a host/fork-name check, so it degrades to existing behavior on hosts where ids already agree.
LoggerManager changes:
CliWrapper awaits the newly-async call.
Tests
outputChannelReveal.test.ts
LoggerManager.test.ts