Added validation for CFD CSCwq28721 #315
Open
sudharson-soundrapandiyan wants to merge 4 commits intodatacenter:masterfrom
Open
Added validation for CFD CSCwq28721 #315sudharson-soundrapandiyan wants to merge 4 commits intodatacenter:masterfrom
sudharson-soundrapandiyan wants to merge 4 commits intodatacenter:masterfrom
Conversation
kahande
reviewed
Jan 2, 2026
Addressing PR comments
kahande
approved these changes
Jan 12, 2026
kahande
left a comment
There was a problem hiding this comment.
Reviewed and appropriate changes are now made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre upgrade validation script log =>
apic1# python3 aci-preupgrade-validation-script_sudharson.py -c '1.1(2b)' -t '6.1(4.10)' -d leaf_ntp_sync_check
==== 2025-12-24T12-20-01+0000, Script Version v4.0.1 ====
!!!! Check https://github.com/datacenter/ACI-Pre-Upgrade-Validation-Script for Latest Release !!!!
To use a non-default Login Domain, enter apic#DOMAIN\USERNAME
Enter username for APIC login : admin
Enter password for corresponding User :
Gathering Node Information...
Current version is overridden to 1.1(2b)
Target APIC version is overridden to 6.1(4.10)
Collecting VPC Node IDs...
Progress: |████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 checks completed
=== Check Result (failed only) ===
[Check 1/1] NTP sync issue in Leaf as NTP server... FAIL - OUTAGE WARNING!!
policy dn pod group name policy name
uni/fabric/time-default default default
Recommended Action: NTP wont sync between leaf as NTP server and host. makesure to use in-band ip for NTP server in leaf or checkout the bug CSCwp92030 for fixed version details
Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#ntp-sync-issue-in-leaf-as-ntp-server
=== Summary Result ===
PASS : 0
FAIL - OUTAGE WARNING!! : 1
FAIL - UPGRADE FAILURE!! : 0
MANUAL CHECK REQUIRED : 0
POST UPGRADE CHECK REQUIRED : 0
N/A : 0
ERROR !! : 0
TOTAL : 1
==== Script Version v4.0.1 FIN ====
apic1#
Pytest Log =>
======================================================= test session starts =======================================================
platform linux -- Python 3.8.10, pytest-7.4.0, pluggy-1.2.0
rootdir: /data/ssd/sudharson/pre_cfd_new/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
collected 8 items
test_leaf_ntp_sync_check.py::test_leaf_ntp_sync_check[icurl_outputs0-6.1(4.10)-6.1(4.15)-PASS]
--------------------------------------------------------- live log setup ----------------------------------------------------------
[12:08:09.871 INFO init_system:6069(MainThread)] Cleaning up previous run files in preupgrade_validator_logs/
[12:08:09.871 INFO init_system:6071(MainThread)] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
---------------------------------------------------------- live log call ----------------------------------------------------------
[12:08:09.873 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
[12:08:09.874 INFO _start_thread:1105(MainThread)] (leaf_ntp_sync_check) Starting thread.
[12:08:09.874 INFO wrapper:1349(leaf_ntp_sync_check)] Start leaf_ntp_sync_check
[12:08:09.875 INFO update_result:1191(leaf_ntp_sync_check)] Finalized result in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
PASSED [ 12%]
test_leaf_ntp_sync_check.py::test_leaf_ntp_sync_check[icurl_outputs1-6.1(4.28)-6.1(4.30)-N/A]
---------------------------------------------------------- live log call ----------------------------------------------------------
[12:08:09.886 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
[12:08:09.887 INFO _start_thread:1105(MainThread)] (leaf_ntp_sync_check) Starting thread.
[12:08:09.888 INFO wrapper:1349(leaf_ntp_sync_check)] Start leaf_ntp_sync_check
[12:08:09.888 INFO update_result:1191(leaf_ntp_sync_check)] Finalized result in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
PASSED [ 25%]
test_leaf_ntp_sync_check.py::test_leaf_ntp_sync_check[icurl_outputs2-6.1(4.10)-6.1(4.15)-PASS]
---------------------------------------------------------- live log call ----------------------------------------------------------
[12:08:09.900 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
[12:08:09.900 INFO _start_thread:1105(MainThread)] (leaf_ntp_sync_check) Starting thread.
[12:08:09.901 INFO wrapper:1349(leaf_ntp_sync_check)] Start leaf_ntp_sync_check
[12:08:09.902 INFO update_result:1191(leaf_ntp_sync_check)] Finalized result in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
PASSED [ 37%]
test_leaf_ntp_sync_check.py::test_leaf_ntp_sync_check[icurl_outputs3-6.1(4.10)-6.1(4.15)-FAIL - OUTAGE WARNING!!]
---------------------------------------------------------- live log call ----------------------------------------------------------
[12:08:09.913 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
[12:08:09.914 INFO _start_thread:1105(MainThread)] (leaf_ntp_sync_check) Starting thread.
[12:08:09.914 INFO wrapper:1349(leaf_ntp_sync_check)] Start leaf_ntp_sync_check
[12:08:09.915 INFO update_result:1191(leaf_ntp_sync_check)] Finalized result in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
PASSED [ 50%]
test_leaf_ntp_sync_check.py::test_leaf_ntp_sync_check[icurl_outputs4-6.1(4.28)-6.1(4.30)-N/A]
---------------------------------------------------------- live log call ----------------------------------------------------------
[12:08:09.926 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
[12:08:09.927 INFO _start_thread:1105(MainThread)] (leaf_ntp_sync_check) Starting thread.
[12:08:09.927 INFO wrapper:1349(leaf_ntp_sync_check)] Start leaf_ntp_sync_check
[12:08:09.928 INFO update_result:1191(leaf_ntp_sync_check)] Finalized result in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
PASSED [ 62%]
test_leaf_ntp_sync_check.py::test_leaf_ntp_sync_check[icurl_outputs5-6.1(4.10)-6.1(4.15)-PASS]
---------------------------------------------------------- live log call ----------------------------------------------------------
[12:08:09.942 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
[12:08:09.943 INFO _start_thread:1105(MainThread)] (leaf_ntp_sync_check) Starting thread.
[12:08:09.943 INFO wrapper:1349(leaf_ntp_sync_check)] Start leaf_ntp_sync_check
[12:08:09.945 INFO update_result:1191(leaf_ntp_sync_check)] Finalized result in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
PASSED [ 75%]
test_leaf_ntp_sync_check.py::test_leaf_ntp_sync_check[icurl_outputs6-6.1(4.10)-6.1(4.15)-FAIL - OUTAGE WARNING!!]
---------------------------------------------------------- live log call ----------------------------------------------------------
[12:08:09.956 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
[12:08:09.957 INFO _start_thread:1105(MainThread)] (leaf_ntp_sync_check) Starting thread.
[12:08:09.958 INFO wrapper:1349(leaf_ntp_sync_check)] Start leaf_ntp_sync_check
[12:08:09.959 INFO update_result:1191(leaf_ntp_sync_check)] Finalized result in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
PASSED [ 87%]
test_leaf_ntp_sync_check.py::test_leaf_ntp_sync_check[icurl_outputs7-6.1(4.10)-6.1(4.15)-FAIL - OUTAGE WARNING!!]
---------------------------------------------------------- live log call ----------------------------------------------------------
[12:08:09.972 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
[12:08:09.973 INFO _start_thread:1105(MainThread)] (leaf_ntp_sync_check) Starting thread.
[12:08:09.973 INFO wrapper:1349(leaf_ntp_sync_check)] Start leaf_ntp_sync_check
[12:08:09.974 INFO update_result:1191(leaf_ntp_sync_check)] Finalized result in preupgrade_validator_logs/json_results/leaf_ntp_sync_check.json
PASSED [100%]
======================================================== 8 passed in 0.12s ========================================================