Skip to content

fix: Pass make_kwargs to make_fetch in tripartite pattern#1359

Closed
dimitri-yatsenko wants to merge 0 commit intomasterfrom
pre/v0.14.7
Closed

fix: Pass make_kwargs to make_fetch in tripartite pattern#1359
dimitri-yatsenko wants to merge 0 commit intomasterfrom
pre/v0.14.7

Conversation

@dimitri-yatsenko
Copy link
Member

Summary

  • Fix make_kwargs not being passed to make_fetch when using the tripartite (generator) pattern

Problem

When using generator-based make with make_fetch, make_compute, and make_insert, the make_kwargs parameter passed to populate() was not forwarded to make_fetch(). This caused a TypeError when users tried to pass keyword arguments to their tripartite make implementation.

Solution

  • Updated make(self, key) to make(self, key, **kwargs)
  • Forward **kwargs to self.make_fetch(key, **kwargs)

Fixes #1350

🤖 Generated with Claude Code

@github-actions github-actions bot added the enhancement Indicates new improvements label Jan 30, 2026
@dimitri-yatsenko dimitri-yatsenko marked this pull request as draft January 30, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Indicates new improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: make_kwargs does not work for generator make

1 participant