Fix #20: implement Connection.isValid() and track close state#51
Open
IceboxDev wants to merge 1 commit intodbeaver:develfrom
Open
Fix #20: implement Connection.isValid() and track close state#51IceboxDev wants to merge 1 commit intodbeaver:develfrom
IceboxDev wants to merge 1 commit intodbeaver:develfrom
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 9 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
LibSqlConnectionpreviously inherited the no-opisValid()fromAbstractJdbcConnection, which throwsSQLFeatureNotSupportedException. This breaks HikariCP / Spring Boot pool validation and causes JetBrains DataGrip / PyCharm to hang for ~50 s after every query while waiting for the unanswered validation call.Three coupled changes, all in
LibSqlConnection:closedstate field.isClosed()previously returned hardcodedfalseandclose()didn't track state. A correctisValid()must short-circuit when the connection is closed, so the close flag has to come along.isValid(int timeout)override. RunsSELECT 1via the sameLibSqlUtils.executeQuerypath the constructor already uses to verify the connection. Wrapped in aCompletableFutureso the spec-mandated timeout actually applies (get(timeout, SECONDS)fortimeout > 0, blockingget()fortimeout == 0). Returnsfalse(does not throw) on any HTTP / SQL failure, per the JDBC contract thatisValid()is a predicate.timeout < 0?SQLExceptionper the JDBC spec.Verified
mvn -f aggregate/pom.xml packageand... testboth pass.Manual integration run against Turso:
isValid(5)?trueisValid(0)?trueisValid(-1)? throwsSQLException("Invalid timeout value: -1")isClosed()?falsebefore close,trueafterisValid(5)after close ?falseLibSqlDriverTest.main()was extended with two of those assertions.