Ensuring changes to icon/webui labels are respected#10
Open
arifer612 wants to merge 2 commits intodcflachs:mainfrom
Open
Ensuring changes to icon/webui labels are respected#10arifer612 wants to merge 2 commits intodcflachs:mainfrom
arifer612 wants to merge 2 commits intodcflachs:mainfrom
Conversation
The changes in this commit clears any prior history of project services in unRAID's cache. It ensures that changes made to the compose file gets properly updated when the project is spun up.
The changes in this commit ensures that cached icons are removed from the server so that changes made to the `net.unraid.docker.icon` are respected.
arifer612
force-pushed
the
feat/update-config
branch
from
8d884be to
eb8a09c
Compare
Author
|
I did not realise that changing the branch name upstream would not reflect in PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes 2 changes. The goal of these 2 changes are to resolve issue #9.
The first is to ensure that projects that are spun down are removed from
unRAID's cache by removing relevant entries in
/usr/local/emhttp/plugins/dynamix.docker.manager/docker.json. This ensuresthat changes to the webui label are respected. This change is not a big change.
The second is to ensure that all cached icon files are removed when a project is
spun down. The files are cached in 2 locations:
/var/lib/docker/unraid/imagesand
/usr/local/emhttp/plugins/dynamix.docker.manager/images. This is a hackyattempt to ensure that changes to the icon label are respected. The reason I say
so is because this means icon files has to be downloaded every time the project
is spun up -- possibly many I/O operations.
Resolves #9