Conversation
src> make && make install examples> make && node AnalysePlayBin.js
old Make system gone
Enable hermetic Emscripten via the emsdk toolchain and switch project WASM config to use it. .bazelrc now configures the emsdk platform/cpu for --config=wasm; BUILD.bazel's wasm config_setting uses values.cpu=wasm. MODULE.bazel adds the emsdk dependency and registers its toolchains. CPPVARIABLES.bzl updates WASM cppopts (adds -fexceptions, removes -mtune=generic). examples/BUILD.bazel now loads emsdk wasm_rules and replaces custom em++ genrules with wasm_cc_binary targets, and updates WASM link options (exceptions and memory flags).
Revise wasm_build.md to remove manual Emscripten install instructions and note that Bazel will automatically download and configure a hermetic emscripten toolchain. Update BUILD.bazel example to use values={"cpu":"wasm"} and mark the code block as python. Adjust CPPVARIABLES and flags (remove -mtune=generic, add -fexceptions). Update .bazelrc examples to use @emsdk//:platform_wasm, add host_cxxopt and compilation_mode=opt. Remove the em++ not found troubleshooting and the recommendation to make em++ explicitly available in CI. Update the compilation flags table to include -fexceptions, -sALLOW_MEMORY_GROWTH=1 and -sINITIAL_MEMORY=268435456.
Rename analyse_play_bin target to AnalysePlayBin and update WASM binary target names and filegroup references; adjust analyse_play_bin.cpp error handling for WASM builds to avoid ErrorMessage and print error code instead; remove deprecated examples/dds.cpp. Also remove -Wno-character-conversion from DDS CPPOPTS. Revise docs/wasm_build.md to use the new WASM target names, simplify available targets list, and trim/clarify WASM-related notes and output instructions.
Collaborator
Author
|
@ed2k, I could not figure a way to add these two commits to your branch. I am happy to merge these changes if you can confirm that you are happy that this is good enough CI coverage for now. You can either add the last two commits to your branch or we can merge this branch. I don't mind which way we do it. |
Closed
Contributor
either way works for me. calling the generated js is good enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118