Escape percent signs in formatter output - #1048
Open
deepakganesh78 wants to merge 1 commit into
Open
Conversation
Prevent formatter-generated percent sequences from being interpreted a second time by util.format or browser consoles, while preserving arbitrary formatter return values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #766.
Custom formatter output is inlined into the first format argument, then interpreted again by Node's
util.formatWithOptionsor the browser console. Percent sequences inside inspected objects were therefore treated as new format specifiers and consumed trailing arguments.This stringifies formatter results and escapes their percent signs before inlining them. The downstream formatting pass converts
%%back to literal%, preserving the formatter output and leaving subsequent arguments untouched. Explicit%%sequences in the user's original format string still follow the existing path unchanged.Validation:
npm run test:node -- --reporter dot— 18 passing%oformatter and the shared custom formatter pathThe repository's pinned XO stack does not run on Node 24 because a transitive dependency calls the removed
util.isDate; lint was therefore run with Node 20.