[codex] Fix best practice resource update and lookup regressions#257
Draft
07-clottattoos-cyber wants to merge 1 commit intodeepmodeling:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two regressions that currently break the official
best_practiceexample workflow described in the documentation.The affected workflow is the documented example that:
host_node/create_resourceto create or update liquid in an existingcontainerworkstation/PumpTransferProtocolto transfer that liquid into another containerIn
v0.10.19, the workflow can fail in two places:create_resourcecrashes when updating an existingRegularContainerPumpTransferProtocolcan fail to resolvefrom_vessel=containerduring resource lookupCloses #256.
Root cause
The first regression comes from an API mismatch during the container state refactor:
RegularContainernow relies onserialize_state()/load_state()append_resourcestill directly accesses.stateThe second regression comes from resource lookup being too bridge-dependent:
containerChanges
append_resourceupdate container state through the current resource state API, while keeping compatibility with legacy.statehost_nodebefore falling back to bridge requestsValidation
Validated in an isolated environment against the official documented workflow:
host_node/create_resourcesucceeds when targeting an existingcontainerworkstation/PumpTransferProtocolsucceeds afterwardsAdditional local check:
python -m py_compile unilabos/ros/nodes/base_device_node.py unilabos/ros/nodes/presets/host_node.py