Add initialization checking in BFGS, and replace the old BFGS with a new one in CG-BFGS.#7117
Merged
19hello merged 8 commits intodeepmodeling:developfrom Apr 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ionic relaxation flow to switch cg_bfgs into the newer/traditional BFGS implementation safely (by adding lazy initialization), and also modifies the OpenMPI stage1 build configuration.
Changes:
- Switch
cg_bfgs -> bfgshandoff to selectrelax_method[1] = "1"(theBFGS/bfgs_tradpath). - Add lazy initialization (
is_initialized) toBFGSsorelax_step()can be called safely without a prior explicitallocate(). - Update the OpenMPI installer to pass explicit compiler selections to
./configure.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| toolchain/scripts/stage1/install_openmpi.sh | Forces compiler variables during OpenMPI configure (may affect toolchain portability). |
| source/source_relax/ions_move_cg.cpp | Changes the cg_bfgs threshold switch to select bfgs_trad (relax_method[1]="1"). |
| source/source_relax/bfgs.h | Adds an is_initialized flag to support safe lazy initialization. |
| source/source_relax/bfgs.cpp | Lazily calls allocate() from relax_step() if needed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
Fix #...
Unit Tests and/or Case Tests for my changes
What's changed?
Any changes of core modules? (ignore if not applicable)