Toolchain: Use fixed commit hash instead of master branch#7193
Open
Growl1234 wants to merge 3 commits intodeepmodeling:developfrom
Open
Toolchain: Use fixed commit hash instead of master branch#7193Growl1234 wants to merge 3 commits intodeepmodeling:developfrom
Growl1234 wants to merge 3 commits intodeepmodeling:developfrom
Conversation
Author
|
The similar issue also exists with LTS branch. |
mohanchen
added
the
Compile & CICD & Docs & Dependencies
Collaborator
|
There is another route of solving dependencies in CMakeLists.txt, consider unifying them? |
QuantumMisaka
approved these changes
Mar 31, 2026
Flying-dragon-boxing
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should never pull directly from a dependency's master branch, as new commits from those repos could break the build process at any time. This PR uses a specific commit hash to pin and download the package instead, and developers should manually edit the hash and sha256 when the update is really needed.
Also removes the outdated patch for Cereal.