Skip to content

Fix eigenvalue parsing for compression-only quantize configs#8057

Open
sowndappan5 wants to merge 3 commits into
deepspeedai:masterfrom
sowndappan5:master
Open

Fix eigenvalue parsing for compression-only quantize configs#8057
sowndappan5 wants to merge 3 commits into
deepspeedai:masterfrom
sowndappan5:master

Conversation

@sowndappan5

@sowndappan5 sowndappan5 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes eigenvalue configuration parsing in deepspeed/runtime/config.py for quantization-enabled configs.

Previously, get_eigenvalue_config() assumed the legacy top-level quantize_training section always existed after get_quantize_enabled() returned true. That caused a KeyError for supported compression configs that enable weight quantization through compression_training without also defining quantize_training.

This change makes the parser fall back to the default eigenvalue settings when the legacy section is absent, while preserving the existing behavior when quantize_training is present.

Testing

Added a regression test covering a compression_training weight-quantization config without a legacy quantize_training section.

Validated locally with the repository's focused pre-commit checks.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e42aef6fb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread deepspeed/runtime/config.py Outdated
@sowndappan5 sowndappan5 requested a review from loadams as a code owner June 10, 2026 07:51
Signed-off-by: Sowndappan S <147894621+sowndappan5@users.noreply.github.com>
Signed-off-by: Sowndappan S <147894621+sowndappan5@users.noreply.github.com>
@sowndappan5 sowndappan5 changed the title Fix NameError in eigenvalue config parsing Fix eigenvalue parsing for compression-only quantize configs Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant