Added Mode::EXECUTABLE flag to gradlew files#13723
Conversation
|
@kbukum1 Could you please review this? |
|
@gmazzo , sorry for late review. I just saw that in the smoke test the mode is getting updated and accordingly content is getting removed. When we update gradle wrapper and create PR, don't we need also gradlew content as well in the PR or we are not sending update for that? |
|
Hi @kbukum1!
You mean in the PR diff? The content of the Assuming you are asking about the diff of the smoke tests, the |
Thanks for the reply. I am going to deploy this one with the smoke test then. Let me know if you see any issue. |
@gmazzo , can you check the smoke test. There are some issues with smoke test? I am rerunning it but seems like it will fail? |
I think it was temporary issue. Now it is passed. Merged smoke test as well. |
|
Thank you both for your support. We're closer and closer to GA 😀 |
|
@kbukum1 was it deployed right? I don't think it worked. I re-runned the PR with Can you verify with the Eng team if the |
|
Ok, apparenly the issue is when "updaing the PR" but, creaing it from scrach does work as expected! Finally:
@kbukum1 you may wan't to double check the "@dependabot recreate" flow with the team, but I think we are ready to start rolling this out. At least I don't have any pending thinkg to test |
|
It seems to be working well But I'll do more tests and confirm |
|
My understanding is that the next step is to rollout the flag incrementally and ultimately remove the flag. As this is a beta flag, I do not believe that people can onboard themselves so we'll need to find volunteers and ask @kbukum1 to enable them. The alternative is for @kbukum1 to pick a few gradle repositories from the logs and enable them incrementally |
@gmazzo , @yeikel sorry for replying late. I will check this on next Tuesday and make plan to rollout the feature flag in the week so we can monitor. I think we can rollout 100% and monitor it 1-2 hours. In mean time, you can check in your repositories. If there is any issue we can turn down the feature flag. Just as a note, for this, incremential is going to be hard to follow. |
|
I will create an issue to do rollout next week. |
|
It seems that this is not working in some scenarios #14027 |
What are you trying to accomplish?
After #13579, we realised that the
executablemode ofgradlewwas lost whendependabotupdates the Gradle Wrapper binaries:https://github.com/gmazzo/gradle-codeowners-plugin/actions/runs/19988292200/job/57325370740?pr=251#step:4:21
Smoke tests PR: https://github.com/gmazzo/gradle-codeowners-plugin/pull/251/files
Anything you want to highlight for special attention from reviewers?
I'm assuming that setting
file.mode = Mode.EXECUTABLEwill be propagated to the PR creation, but needs validation from mantainers.How will you know you've accomplished your goal?
Since I can't run (or don't know how) to run
dependabotlocally to open real PRs, I rely on smoke tests to validate the change.The run with

dependabot testreveals that now a newmode: 100755is added into the output YAML:Checklist