Open
Conversation
🦋 Changeset detectedLatest commit: 43b8ee0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Truffle dependency to use a minimum version of what is now the latest one out, which uses a later version of pouchdb incorporating a fix for a high severity vulnerability in node-fetch.
Simply relying on the caret notation and running
npm audit fixwill not necessarily work, because that will lead to updating the version of web3 used in Truffle to its latest version, which included a breaking change on the patch release number which has not yet been resolved to again bring Truffle's types back into consistency with web3's changed typings; Typescript compilation fails.Increasing this minimum version, in this case, enhances security.