Add rootless Docker support and update documentation#1549
Add rootless Docker support and update documentation#1549sireeshajonnalagadda wants to merge 9 commits intodevcontainers:mainfrom
Conversation
Kaniska244
left a comment
Kaniska244
left a comment
There was a problem hiding this comment.
I have left few comments. Please get back in case of any issues.
| buildx=(docker-buildx-plugin) | ||
| fi | ||
| apt-get -y install --no-install-recommends ${cli_package_name}${cli_version_suffix} "${buildx[@]}" docker-compose-plugin | ||
| if [ "${DOCKER_DASH_COMPOSE_VERSION}" != "v1" ]; then |
There was a problem hiding this comment.
What is the relevance of this check for rootless Docker support?
There was a problem hiding this comment.
Why do we have this documentation in the test directory? If any change required, couldn't this be done in the readme file or even as PR comment if applicable?
| ], | ||
| "containerUser": "vscode" | ||
| }, | ||
| "xdg_runtime_dir_socket": { |
There was a problem hiding this comment.
Why do we really need this test when it appears to be quite similar to rootless_docker_socket scenario?
| "moby": false | ||
| } | ||
| }, | ||
| "mounts": [ |
There was a problem hiding this comment.
Do we really need the explicit mounts for this case as I guess this should be the default behavior. isn't it?
| }, | ||
| "installDockerComposeSwitch": { | ||
| "type": "boolean", | ||
| "default": true, |
There was a problem hiding this comment.
Although not quite related to this PR, can we make this flag as false by default to align the behavior with the d-in-d feature? This is because the compose-switch component which is installed using this flag is obsolete and not really required by default as the docker compose v2 is the default configuration for the feature.
2 participants
This PR fixes the issue for rootless docker
Checklist
Changes works as expected for both root and rootless docker environments.