Conversation
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
thepetk
force-pushed
the
feat/deprecate_go_stacks
branch
from
08959a0 to
ae703d8
Compare
|
@michael-valdron I've included my updates for the The action is currently failing for all PRs as we have a problem with the More specifically, after the #624 was merged, this check is now able to fetch correctly the paths, so it's able to recognize the related sample and tries to verify its schema. Now as we haven't set That said I'm adding this flag just to make it ignore looking for files like |
thepetk
force-pushed
the
feat/deprecate_go_stacks
branch
from
ae703d8 to
0461f1e
Compare
|
Rebased to latest main |
|
/retest |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
Hi @thepetk, apologies for missing your PR here, if you can rebase it when you can I'll give a re-review.
|
lol @michael-valdron I have forgotten about it too :D Thanks for bringing it up again |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
force-pushed
the
feat/deprecate_go_stacks
branch
from
0461f1e to
58c94fe
Compare
|
@michael-valdron rebased |
|
@thepetk: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
Passed integration tests I ran ✔️
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Description of Changes
Adds a
deprecatedlabel to the old golang stacks (goversion older thanv1.23and also skips them from renovate updates.Related Issue(s)
N/A
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.