Skip to content

fix(redfish): fixed failures on redfish protocol validator#823

Merged
sudhir-intc merged 4 commits intoredfishfrom
redfish_protocol_fix
Mar 20, 2026
Merged

fix(redfish): fixed failures on redfish protocol validator#823
sudhir-intc merged 4 commits intoredfishfrom
redfish_protocol_fix

Conversation

@DevipriyaS17
Copy link
Copy Markdown
Contributor

@DevipriyaS17 DevipriyaS17 commented Mar 5, 2026

  • Added /redfish version endpoint
  • Fixed OData service context and header validation
  • Enhanced response headers (Link, Allow, WWW-Authenticate)
  • Removed single-session-per-user restriction
  • Added POST to /SessionService/Sessions/Members

Fixed 17 of 20 DMTF Protocol Validator failures.

Results
FAIL: 20 → 3

@DevipriyaS17 DevipriyaS17 linked an issue Mar 5, 2026 that may be closed by this pull request
@DevipriyaS17 DevipriyaS17 force-pushed the redfish_protocol_fix branch 2 times, most recently from 1600a7d to 7270d18 Compare March 5, 2026 08:52
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 27.19298% with 83 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (redfish@250513a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nternal/controller/http/v1/generated/server.gen.go 0.00% 65 Missing ⚠️
redfish/component.go 22.22% 7 Missing ⚠️
...fish/internal/controller/http/v1/handler/errors.go 84.37% 5 Missing ⚠️
...nternal/controller/http/v1/handler/service_root.go 20.00% 4 Missing ⚠️
...sh/internal/controller/http/v1/handler/sessions.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             redfish     #823   +/-   ##
==========================================
  Coverage           ?   34.16%           
==========================================
  Files              ?      135           
  Lines              ?    14227           
  Branches           ?        0           
==========================================
  Hits               ?     4860           
  Misses             ?     8932           
  Partials           ?      435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DevipriyaS17 DevipriyaS17 marked this pull request as ready for review March 6, 2026 05:03
Comment thread redfish/component.go Outdated
Comment thread redfish/component.go Outdated
Comment thread redfish/internal/controller/http/v1/handler/service_root.go
Comment thread config/config_test.go Outdated
Comment thread internal/controller/httpapi/v1/devices_test.go Outdated
Comment thread internal/controller/httpapi/v1/ciraconfigs_test.go Outdated
Comment thread internal/controller/httpapi/v1/kvm_test.go Outdated
Comment thread redfish/internal/controller/http/v1/handler/middleware_test.go Outdated
Comment thread redfish/internal/controller/http/v1/handler/service_root.go
@DevipriyaS17 DevipriyaS17 force-pushed the redfish_protocol_fix branch from 6c6db83 to f020e77 Compare March 20, 2026 05:08
@sudhir-intc sudhir-intc dismissed their stale review March 20, 2026 08:52

Changes completed

@sudhir-intc sudhir-intc merged commit 933f299 into redfish Mar 20, 2026
15 checks passed
@sudhir-intc sudhir-intc deleted the redfish_protocol_fix branch March 20, 2026 08:53
@RosieAMT
Copy link
Copy Markdown

🎉 This PR is included in version 1.20.0-redfish-test-preview.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RosieAMT
Copy link
Copy Markdown

🎉 This PR is included in version 1.20.0-redfish-preview.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

DevipriyaS17 added a commit that referenced this pull request Apr 10, 2026
* fix(redfish): fixed failures on redfish protocol validator

* fix(redfish): generated api file for redfish and session members endpoint and computer system boot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Redfish] Resolve issues in the Redfish protocol validator tests

3 participants