refactor!: Overhaul cycles handling - new amount formats, display changes, and cycles transfer command #293
+823
−264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viviveevee
changed the title
raymondk
reviewed
Jan 22, 2026
Contributor
|
Notes from standup:
|
raymondk
reviewed
Jan 23, 2026
| // Display results | ||
| let _ = ctx.term.write_line(&format!( | ||
| "Minted {} TCYCLES to your account, new balance: {} TCYCLES.", | ||
| "Minted {} to your account, new balance: {}.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Minted {} to your account, new balance: {}.", | |
| "Minted {} cycles to your account, new balance: {} cycles.", |
Contributor
Author
There was a problem hiding this comment.
The symbol is included in the struct that is displayed
raymondk
reviewed
Jan 23, 2026
| transfer_info.receiver, | ||
| transfer_info.block_index | ||
| "Transferred {} to {} in block {}", | ||
| transfer_info.transferred, transfer_info.receiver, transfer_info.block_index |
Contributor
There was a problem hiding this comment.
Why not show the symbol here?
Contributor
Author
There was a problem hiding this comment.
Same here, it's in the displayed struct
adamspofford-dfinity
approved these changes
Jan 23, 2026
viviveevee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCYCLESin favor ofcyclescycles_is allowed and ignored:1_000parses to1000k,m,b,tsuffixes (case insensitive) to avoid typing a bunch of zeroes1_234.56Kparses to1234560